components/content_settings/core/browser/BUILD.gn - Issue 670953006: Componentize HostContentSettingsMap and content settings providers.

Side by Side Diff: components/content_settings/core/browser/BUILD.gn

Issue 670953006: Componentize HostContentSettingsMap and content settings providers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/content_settings.gypi ('K') | « components/content_settings.gypi ('k') | components/content_settings/core/browser/DEPS » ('j') | components/content_settings/core/browser/host_content_settings_map.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("browser") {	5 static_library("browser") {

6 sources = [	6 sources = [

7 "content_settings_client.h",	7 "content_settings_client.h",

8 "content_settings_details.cc",	8 "content_settings_details.cc",

9 "content_settings_details.h",	9 "content_settings_details.h",

10 "content_settings_observer.h",	10 "content_settings_observer.h",

11 "content_settings_provider.h",	11 "content_settings_provider.h",

12 "content_settings_observable_provider.cc",	12 "content_settings_observable_provider.cc",

13 "content_settings_observable_provider.h",	13 "content_settings_observable_provider.h",

14 "content_settings_origin_identifier_value_map.cc",	14 "content_settings_origin_identifier_value_map.cc",

15 "content_settings_origin_identifier_value_map.h",	15 "content_settings_origin_identifier_value_map.h",

16 "content_settings_rule.cc",	16 "content_settings_rule.cc",

17 "content_settings_rule.h",	17 "content_settings_rule.h",

18 "local_shared_objects_counter.h",	18 "local_shared_objects_counter.h",

	19 'content_settings/core/browser/content_settings_default_provider.cc',
	vabr (Chromium) 2014/10/24 07:06:31 nit: alphabetise nit: alphabetise vabr (Chromium) 2014/10/24 07:06:31 nit: drop the paths, leave just the file names nit: drop the paths, leave just the file names vabr (Chromium) 2014/10/24 07:06:31 nit: use double quotes (") instead of apostrophe ( nit: use double quotes (") instead of apostrophe (') vabr (Chromium) 2014/10/24 07:06:31 nit: indenting nit: indenting Jun Mukai 2014/10/24 21:17:01 Done. Show quoted text On 2014/10/24 07:06:31, vabr (Chromium) wrote: > nit: indenting Done.
	20 'content_settings/core/browser/content_settings_default_provider.h',

	21 'content_settings/core/browser/content_settings_override_provider.cc',

	22 'content_settings/core/browser/content_settings_override_provider.h',

	23 'content_settings/core/browser/content_settings_policy_provider.cc',

	24 'content_settings/core/browser/content_settings_policy_provider.h',

	25 'content_settings/core/browser/content_settings_pref_provider.cc',

	26 'content_settings/core/browser/content_settings_pref_provider.h',

	27 'content_settings/core/browser/content_settings_utils.cc',

	28 'content_settings/core/browser/content_settings_utils.h',

	29 'content_settings/core/browser/host_content_settings_map.cc',

	30 'content_settings/core/browser/host_content_settings_map.h',

19 ]	31 ]

20	32

21 deps = [	33 deps = [

22 "//base",	34 "//base",

23 "//components/content_settings/core/common",	35 "//components/content_settings/core/common",

24 ]	36 ]

25 }	37 }

26	38

27 source_set("unit_tests") {	39 source_set("unit_tests") {

28 testonly = true	40 testonly = true

29 sources = [	41 sources = [

30 "content_settings_rule_unittest.cc",	42 "content_settings_rule_unittest.cc",

	43 'content_settings/core/browser/content_settings_mock_provider.cc',
	vabr (Chromium) 2014/10/24 07:06:31 ditto all four nits from above ditto all four nits from above Jun Mukai 2014/10/24 21:17:01 Done. Show quoted text On 2014/10/24 07:06:31, vabr (Chromium) wrote: > ditto all four nits from above Done.
	44 'content_settings/core/browser/content_settings_mock_provider.h',

	45 'content_settings/core/browser/content_settings_provider_unittest.cc',

	46 'content_settings/core/browser/content_settings_utils_unittest.cc',

31 ]	47 ]

32	48

33 deps = [	49 deps = [

34 ":browser",	50 ":browser",

35 "//testing/gtest",	51 "//testing/gtest",

36 ]	52 ]

37 }	53 }

OLD	NEW