Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3944)

Unified Diff: chrome/browser/content_settings/content_settings_utils_unittest.cc

Issue 670953006: Componentize HostContentSettingsMap and content settings providers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win64 suppress warnings Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_utils_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_utils_unittest.cc b/chrome/browser/content_settings/content_settings_utils_unittest.cc
deleted file mode 100644
index d5eeecac3056cb147b130975715f7d3ba623c1a0..0000000000000000000000000000000000000000
--- a/chrome/browser/content_settings/content_settings_utils_unittest.cc
+++ /dev/null
@@ -1,45 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/content_settings/content_settings_utils.h"
-
-#include <string>
-
-#include "testing/gtest/include/gtest/gtest.h"
-
-TEST(ContentSettingsUtilsTest, ParsePatternString) {
- content_settings::PatternPair pattern_pair;
-
- pattern_pair = content_settings::ParsePatternString(std::string());
- EXPECT_FALSE(pattern_pair.first.IsValid());
- EXPECT_FALSE(pattern_pair.second.IsValid());
-
- pattern_pair = content_settings::ParsePatternString(",");
- EXPECT_FALSE(pattern_pair.first.IsValid());
- EXPECT_FALSE(pattern_pair.second.IsValid());
-
- pattern_pair = content_settings::ParsePatternString("http://www.foo.com");
- EXPECT_TRUE(pattern_pair.first.IsValid());
- EXPECT_EQ(pattern_pair.second, ContentSettingsPattern::Wildcard());
-
- // This inconsistency is to recover from some broken code.
- pattern_pair = content_settings::ParsePatternString("http://www.foo.com,");
- EXPECT_TRUE(pattern_pair.first.IsValid());
- EXPECT_FALSE(pattern_pair.second.IsValid());
-
- pattern_pair = content_settings::ParsePatternString(
- "http://www.foo.com,http://www.bar.com");
- EXPECT_TRUE(pattern_pair.first.IsValid());
- EXPECT_TRUE(pattern_pair.second.IsValid());
-
- pattern_pair = content_settings::ParsePatternString(
- "http://www.foo.com,http://www.bar.com,");
- EXPECT_FALSE(pattern_pair.first.IsValid());
- EXPECT_FALSE(pattern_pair.second.IsValid());
-
- pattern_pair = content_settings::ParsePatternString(
- "http://www.foo.com,http://www.bar.com,http://www.error.com");
- EXPECT_FALSE(pattern_pair.first.IsValid());
- EXPECT_FALSE(pattern_pair.second.IsValid());
-}
« no previous file with comments | « chrome/browser/content_settings/content_settings_utils.cc ('k') | chrome/browser/content_settings/cookie_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698