Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 670953003: Move feedback slot allocation to post-pass (Closed)

Created:
6 years, 2 months ago by wingo
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne, mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -96 lines) Patch
M src/ast.h View 1 8 chunks +13 lines, -20 lines 0 comments Download
M src/ast.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M src/ast-numbering.cc View 1 9 chunks +22 lines, -4 lines 0 comments Download
M src/compiler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.cc View 1 2 chunks +13 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/liveedit.h View 4 chunks +2 lines, -11 lines 0 comments Download
M src/liveedit.cc View 4 chunks +18 lines, -24 lines 0 comments Download
M src/parser.cc View 1 7 chunks +0 lines, -10 lines 0 comments Download
M src/preparser.h View 1 5 chunks +0 lines, -13 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
wingo
Based on https://codereview.chromium.org/668143003/, PTAL once that one has been reviewed
6 years, 1 month ago (2014-10-27 07:45:35 UTC) #4
mvstanton
Looks pretty nice. How about we'll let the first CL go in and get some ...
6 years, 1 month ago (2014-10-27 11:46:02 UTC) #6
mvstanton
Respecting the master ordering, it LGTM. thanks!
6 years, 1 month ago (2014-10-30 13:08:43 UTC) #7
wingo
On 2014/10/30 13:08:43, mvstanton wrote: > Respecting the master ordering, it LGTM. > thanks! Cheers. ...
6 years, 1 month ago (2014-11-13 10:46:58 UTC) #8
wingo
6 years, 1 month ago (2014-11-14 08:21:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:80001) manually as
1503d0e78c6b146c64f2bc028c534d5dd57d6944 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698