Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: src/parser.cc

Issue 670953003: Move feedback slot allocation to post-pass (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased patch Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/liveedit.cc ('k') | src/preparser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index 0301e40851d5c4da1f09b77ed0728517762fe997..721d4caada4450e486f98c2a239d4224e1088e3d 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -277,7 +277,6 @@ FunctionLiteral* Parser::DefaultConstructor(bool call_super, Scope* scope,
int expected_property_count = -1;
int handler_count = 0;
int parameter_count = 0;
- AstProperties ast_properties;
const AstRawString* name = ast_value_factory()->empty_string();
FunctionKind kind = call_super ? FunctionKind::kDefaultConstructorCallSuper
: FunctionKind::kDefaultConstructor;
@@ -309,8 +308,6 @@ FunctionLiteral* Parser::DefaultConstructor(bool call_super, Scope* scope,
materialized_literal_count = function_state.materialized_literal_count();
expected_property_count = function_state.expected_property_count();
handler_count = function_state.handler_count();
-
- ast_properties = *factory()->visitor()->ast_properties();
}
FunctionLiteral* function_literal = factory()->NewFunctionLiteral(
@@ -320,8 +317,6 @@ FunctionLiteral* Parser::DefaultConstructor(bool call_super, Scope* scope,
FunctionLiteral::ANONYMOUS_EXPRESSION, FunctionLiteral::kIsFunction,
FunctionLiteral::kNotParenthesized, kind, pos);
- function_literal->set_ast_properties(&ast_properties);
-
return function_literal;
}
@@ -968,7 +963,6 @@ FunctionLiteral* Parser::DoParseProgram(CompilationInfo* info, Scope** scope,
FunctionLiteral::kNoDuplicateParameters,
FunctionLiteral::ANONYMOUS_EXPRESSION, FunctionLiteral::kGlobalOrEval,
FunctionLiteral::kNotParenthesized, FunctionKind::kNormalFunction, 0);
- result->set_ast_properties(factory()->visitor()->ast_properties());
}
}
@@ -3554,7 +3548,6 @@ FunctionLiteral* Parser::ParseFunctionLiteral(
FunctionLiteral::IsParenthesizedFlag parenthesized = parenthesized_function_
? FunctionLiteral::kIsParenthesized
: FunctionLiteral::kNotParenthesized;
- AstProperties ast_properties;
// Parse function body.
{
AstNodeFactory<AstConstructionVisitor> function_factory(
@@ -3722,8 +3715,6 @@ FunctionLiteral* Parser::ParseFunctionLiteral(
scope->end_position(),
CHECK_OK);
}
- ast_properties = *factory()->visitor()->ast_properties();
-
if (allow_harmony_scoping() && strict_mode() == STRICT) {
CheckConflictingVarDeclarations(scope, CHECK_OK);
}
@@ -3735,7 +3726,6 @@ FunctionLiteral* Parser::ParseFunctionLiteral(
num_parameters, duplicate_parameters, function_type,
FunctionLiteral::kIsFunction, parenthesized, kind, pos);
function_literal->set_function_token_position(function_token_pos);
- function_literal->set_ast_properties(&ast_properties);
if (fni_ != NULL && should_infer_name) fni_->AddFunction(function_literal);
return function_literal;
« no previous file with comments | « src/liveedit.cc ('k') | src/preparser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698