Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: src/preparser.h

Issue 670953003: Move feedback slot allocation to post-pass (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased patch Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parser.cc ('k') | test/cctest/test-compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/preparser.h
diff --git a/src/preparser.h b/src/preparser.h
index 8b78d46a3a0eda84af92d6ce51d2d05131dec774..c44731279e734bf9387f9fe2111c481919e7af53 100644
--- a/src/preparser.h
+++ b/src/preparser.h
@@ -815,7 +815,6 @@ class PreParserExpression {
int position() const { return RelocInfo::kNoPosition; }
void set_function_token_position(int position) {}
- void set_ast_properties(int* ast_properties) {}
private:
enum Type {
@@ -1098,14 +1097,6 @@ class PreParserFactory {
int start_position, int end_position) {
return PreParserExpression::Default();
}
-
- // Return the object itself as AstVisitor and implement the needed
- // dummy method right in this class.
- PreParserFactory* visitor() { return this; }
- int* ast_properties() {
- static int dummy = 42;
- return &dummy;
- }
};
@@ -2632,7 +2623,6 @@ typename ParserBase<Traits>::ExpressionT ParserBase<
bool* ok) {
typename Traits::Type::ScopePtr scope = this->NewScope(scope_, ARROW_SCOPE);
typename Traits::Type::StatementList body;
- typename Traits::Type::AstProperties ast_properties;
int num_parameters = -1;
int materialized_literal_count = -1;
int expected_property_count = -1;
@@ -2714,8 +2704,6 @@ typename ParserBase<Traits>::ExpressionT ParserBase<
if (allow_harmony_scoping() && strict_mode() == STRICT)
this->CheckConflictingVarDeclarations(scope, CHECK_OK);
-
- ast_properties = *factory()->visitor()->ast_properties();
}
FunctionLiteralT function_literal = factory()->NewFunctionLiteral(
@@ -2727,7 +2715,6 @@ typename ParserBase<Traits>::ExpressionT ParserBase<
start_pos);
function_literal->set_function_token_position(start_pos);
- function_literal->set_ast_properties(&ast_properties);
if (fni_ != NULL) this->InferFunctionName(fni_, function_literal);
« no previous file with comments | « src/parser.cc ('k') | test/cctest/test-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698