Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2406)

Unified Diff: content/renderer/pepper/host_var_tracker_unittest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/host_var_tracker.h ('k') | content/renderer/pepper/message_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/host_var_tracker_unittest.cc
diff --git a/content/renderer/pepper/host_var_tracker_unittest.cc b/content/renderer/pepper/host_var_tracker_unittest.cc
index 356d43d5eee265cfb37bd28e1a3186e26169e888..3c8bff28c66a337bfbe80023abfc940ec17ab3a0 100644
--- a/content/renderer/pepper/host_var_tracker_unittest.cc
+++ b/content/renderer/pepper/host_var_tracker_unittest.cc
@@ -36,7 +36,7 @@ class MyObject : public gin::Wrappable<MyObject> {
private:
MyObject() { ++g_v8objects_alive; }
- virtual ~MyObject() { --g_v8objects_alive; }
+ ~MyObject() override { --g_v8objects_alive; }
DISALLOW_COPY_AND_ASSIGN(MyObject);
};
@@ -51,9 +51,9 @@ class PepperTryCatchForTest : public PepperTryCatch {
handle_scope_(instance->GetIsolate()),
context_scope_(v8::Context::New(instance->GetIsolate())) {}
- virtual void SetException(const char* message) override { NOTREACHED(); }
- virtual bool HasException() override { return false; }
- virtual v8::Handle<v8::Context> GetContext() override {
+ void SetException(const char* message) override { NOTREACHED(); }
+ bool HasException() override { return false; }
+ v8::Handle<v8::Context> GetContext() override {
return instance_->GetIsolate()->GetCurrentContext();
}
« no previous file with comments | « content/renderer/pepper/host_var_tracker.h ('k') | content/renderer/pepper/message_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698