Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: content/renderer/pepper/host_var_tracker.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/host_resource_var.h ('k') | content/renderer/pepper/host_var_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/host_var_tracker.h
diff --git a/content/renderer/pepper/host_var_tracker.h b/content/renderer/pepper/host_var_tracker.h
index 56f471033637b7d69c83f8de8915bb28245485a8..0be5d1d2eb63cce86bc6e7382c8b2b233875cc5f 100644
--- a/content/renderer/pepper/host_var_tracker.h
+++ b/content/renderer/pepper/host_var_tracker.h
@@ -31,7 +31,7 @@ namespace content {
class HostVarTracker : public ppapi::VarTracker {
public:
HostVarTracker();
- virtual ~HostVarTracker();
+ ~HostVarTracker() override;
// Tracks all live V8ObjectVar. This is so we can map between instance +
// V8Object and get the V8ObjectVar corresponding to it. This Add/Remove
@@ -46,27 +46,25 @@ class HostVarTracker : public ppapi::VarTracker {
CONTENT_EXPORT int GetLiveV8ObjectVarsForTest(PP_Instance instance);
// VarTracker public implementation.
- virtual PP_Var MakeResourcePPVarFromMessage(
- PP_Instance instance,
- const IPC::Message& creation_message,
- int pending_renderer_id,
- int pending_browser_id) override;
- virtual ppapi::ResourceVar* MakeResourceVar(PP_Resource pp_resource) override;
- virtual void DidDeleteInstance(PP_Instance pp_instance) override;
-
- virtual int TrackSharedMemoryHandle(PP_Instance instance,
- base::SharedMemoryHandle file,
- uint32 size_in_bytes) override;
- virtual bool StopTrackingSharedMemoryHandle(int id,
- PP_Instance instance,
- base::SharedMemoryHandle* handle,
- uint32* size_in_bytes) override;
+ PP_Var MakeResourcePPVarFromMessage(PP_Instance instance,
+ const IPC::Message& creation_message,
+ int pending_renderer_id,
+ int pending_browser_id) override;
+ ppapi::ResourceVar* MakeResourceVar(PP_Resource pp_resource) override;
+ void DidDeleteInstance(PP_Instance pp_instance) override;
+
+ int TrackSharedMemoryHandle(PP_Instance instance,
+ base::SharedMemoryHandle file,
+ uint32 size_in_bytes) override;
+ bool StopTrackingSharedMemoryHandle(int id,
+ PP_Instance instance,
+ base::SharedMemoryHandle* handle,
+ uint32* size_in_bytes) override;
private:
// VarTracker private implementation.
- virtual ppapi::ArrayBufferVar* CreateArrayBuffer(uint32 size_in_bytes)
- override;
- virtual ppapi::ArrayBufferVar* CreateShmArrayBuffer(
+ ppapi::ArrayBufferVar* CreateArrayBuffer(uint32 size_in_bytes) override;
+ ppapi::ArrayBufferVar* CreateShmArrayBuffer(
uint32 size_in_bytes,
base::SharedMemoryHandle handle) override;
« no previous file with comments | « content/renderer/pepper/host_resource_var.h ('k') | content/renderer/pepper/host_var_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698