Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2819)

Unified Diff: content/renderer/pepper/message_channel.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/message_channel.h
diff --git a/content/renderer/pepper/message_channel.h b/content/renderer/pepper/message_channel.h
index 02e29e38ef74c9eb37e5b53271010760ea444c25..4889777ed76de51152bb7b6a3030fe9660ac993e 100644
--- a/content/renderer/pepper/message_channel.h
+++ b/content/renderer/pepper/message_channel.h
@@ -61,7 +61,7 @@ class MessageChannel :
static MessageChannel* Create(PepperPluginInstanceImpl* instance,
v8::Persistent<v8::Object>* result);
- virtual ~MessageChannel();
+ ~MessageChannel() override;
// Called when the instance is deleted. The MessageChannel might outlive the
// plugin instance because it is garbage collected.
@@ -93,22 +93,21 @@ class MessageChannel :
explicit MessageChannel(PepperPluginInstanceImpl* instance);
// gin::NamedPropertyInterceptor
- virtual v8::Local<v8::Value> GetNamedProperty(
- v8::Isolate* isolate,
- const std::string& property) override;
- virtual bool SetNamedProperty(v8::Isolate* isolate,
- const std::string& property,
- v8::Local<v8::Value> value) override;
- virtual std::vector<std::string> EnumerateNamedProperties(
+ v8::Local<v8::Value> GetNamedProperty(v8::Isolate* isolate,
+ const std::string& property) override;
+ bool SetNamedProperty(v8::Isolate* isolate,
+ const std::string& property,
+ v8::Local<v8::Value> value) override;
+ std::vector<std::string> EnumerateNamedProperties(
v8::Isolate* isolate) override;
// gin::Wrappable
- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
// ppapi::proxy::HostDispatcher::SyncMessageStatusObserver
- virtual void BeginBlockOnSyncMessage() override;
- virtual void EndBlockOnSyncMessage() override;
+ void BeginBlockOnSyncMessage() override;
+ void EndBlockOnSyncMessage() override;
// Post a message to the plugin's HandleMessage function for this channel's
// instance.
« no previous file with comments | « content/renderer/pepper/host_var_tracker_unittest.cc ('k') | content/renderer/pepper/mock_renderer_ppapi_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698