Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3283)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc
index 9adaa29d95461dd5b64d11aea0347889a33a48c5..f07d88d1b9cfcfcfb475eb3ac3c4b2bb3a2eadd0 100644
--- a/content/renderer/media/rtc_peer_connection_handler.cc
+++ b/content/renderer/media/rtc_peer_connection_handler.cc
@@ -202,18 +202,18 @@ class CreateSessionDescriptionRequest
PeerConnectionTracker::Action action)
: webkit_request_(request), tracker_(handler, action) {}
- virtual void OnSuccess(webrtc::SessionDescriptionInterface* desc) override {
+ void OnSuccess(webrtc::SessionDescriptionInterface* desc) override {
tracker_.TrackOnSuccess(desc);
webkit_request_.requestSucceeded(CreateWebKitSessionDescription(desc));
delete desc;
}
- virtual void OnFailure(const std::string& error) override {
+ void OnFailure(const std::string& error) override {
tracker_.TrackOnFailure(error);
webkit_request_.requestFailed(base::UTF8ToUTF16(error));
}
protected:
- virtual ~CreateSessionDescriptionRequest() {}
+ ~CreateSessionDescriptionRequest() override {}
private:
blink::WebRTCSessionDescriptionRequest webkit_request_;
@@ -231,17 +231,17 @@ class SetSessionDescriptionRequest
PeerConnectionTracker::Action action)
: webkit_request_(request), tracker_(handler, action) {}
- virtual void OnSuccess() override {
+ void OnSuccess() override {
tracker_.TrackOnSuccess(NULL);
webkit_request_.requestSucceeded();
}
- virtual void OnFailure(const std::string& error) override {
+ void OnFailure(const std::string& error) override {
tracker_.TrackOnFailure(error);
webkit_request_.requestFailed(base::UTF8ToUTF16(error));
}
protected:
- virtual ~SetSessionDescriptionRequest() {}
+ ~SetSessionDescriptionRequest() override {}
private:
blink::WebRTCVoidRequest webkit_request_;
@@ -258,7 +258,7 @@ class StatsResponse : public webrtc::StatsObserver {
TRACE_EVENT_ASYNC_BEGIN0("webrtc", "getStats_Native", this);
}
- virtual void OnComplete(const StatsReports& reports) override {
+ void OnComplete(const StatsReports& reports) override {
TRACE_EVENT0("webrtc", "StatsResponse::OnComplete")
for (StatsReports::const_iterator it = reports.begin();
it != reports.end(); ++it) {
@@ -347,17 +347,17 @@ namespace {
class PeerConnectionUMAObserver : public webrtc::UMAObserver {
public:
PeerConnectionUMAObserver() {}
- virtual ~PeerConnectionUMAObserver() {}
+ ~PeerConnectionUMAObserver() override {}
- virtual void IncrementCounter(
+ void IncrementCounter(
webrtc::PeerConnectionUMAMetricsCounter counter) override {
UMA_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.IPMetrics",
counter,
webrtc::kBoundary);
}
- virtual void AddHistogramSample(
- webrtc::PeerConnectionUMAMetricsName type, int value) override {
+ void AddHistogramSample(webrtc::PeerConnectionUMAMetricsName type,
+ int value) override {
switch (type) {
case webrtc::kTimeToConnect:
UMA_HISTOGRAM_MEDIUM_TIMES(
« no previous file with comments | « content/renderer/media/rtc_peer_connection_handler.h ('k') | content/renderer/media/rtc_peer_connection_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698