Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: content/renderer/media/rtc_peer_connection_handler_unittest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/rtc_peer_connection_handler.cc ('k') | content/renderer/media/rtc_video_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/rtc_peer_connection_handler_unittest.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler_unittest.cc b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
index 0c95ca05b4b8a9ae4bc7c24217ad77c4ce5af9d5..aac53423f2f6f18f49e56f429d9fbf7ca89daf41 100644
--- a/content/renderer/media/rtc_peer_connection_handler_unittest.cc
+++ b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
@@ -60,16 +60,16 @@ class MockRTCStatsResponse : public LocalRTCStatsResponse {
statistic_count_(0) {
}
- virtual size_t addReport(blink::WebString type,
- blink::WebString id,
- double timestamp) override {
+ size_t addReport(blink::WebString type,
+ blink::WebString id,
+ double timestamp) override {
++report_count_;
return report_count_;
}
- virtual void addStatistic(size_t report,
- blink::WebString name, blink::WebString value)
- override {
+ void addStatistic(size_t report,
+ blink::WebString name,
+ blink::WebString value) override {
++statistic_count_;
}
int report_count() const { return report_count_; }
@@ -86,20 +86,15 @@ class MockRTCStatsRequest : public LocalRTCStatsRequest {
: has_selector_(false),
request_succeeded_called_(false) {}
- virtual bool hasSelector() const override {
- return has_selector_;
- }
- virtual blink::WebMediaStreamTrack component() const override {
- return component_;
- }
- virtual scoped_refptr<LocalRTCStatsResponse> createResponse() override {
+ bool hasSelector() const override { return has_selector_; }
+ blink::WebMediaStreamTrack component() const override { return component_; }
+ scoped_refptr<LocalRTCStatsResponse> createResponse() override {
DCHECK(!response_.get());
response_ = new rtc::RefCountedObject<MockRTCStatsResponse>();
return response_;
}
- virtual void requestSucceeded(const LocalRTCStatsResponse* response)
- override {
+ void requestSucceeded(const LocalRTCStatsResponse* response) override {
EXPECT_EQ(response, response_.get());
request_succeeded_called_ = true;
}
« no previous file with comments | « content/renderer/media/rtc_peer_connection_handler.cc ('k') | content/renderer/media/rtc_video_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698