Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.h
diff --git a/content/renderer/media/rtc_peer_connection_handler.h b/content/renderer/media/rtc_peer_connection_handler.h
index 544658833ef42b84f861af426f58aaa9827ad897..0a32c0f11c919b120960c905f2fe7bf486b84cf9 100644
--- a/content/renderer/media/rtc_peer_connection_handler.h
+++ b/content/renderer/media/rtc_peer_connection_handler.h
@@ -46,7 +46,7 @@ class CONTENT_EXPORT LocalRTCStatsResponse
blink::WebString name, blink::WebString value);
protected:
- virtual ~LocalRTCStatsResponse() {}
+ ~LocalRTCStatsResponse() override {}
// Constructor for creating mocks.
LocalRTCStatsResponse() {}
@@ -68,7 +68,7 @@ class CONTENT_EXPORT LocalRTCStatsRequest
virtual scoped_refptr<LocalRTCStatsResponse> createResponse();
protected:
- virtual ~LocalRTCStatsRequest();
+ ~LocalRTCStatsRequest() override;
private:
blink::WebRTCStatsRequest impl_;
@@ -159,22 +159,20 @@ class CONTENT_EXPORT RTCPeerConnectionHandler
virtual void stop() override;
// webrtc::PeerConnectionObserver implementation
- virtual void OnError() override;
+ void OnError() override;
// Triggered when the SignalingState changed.
- virtual void OnSignalingChange(
+ void OnSignalingChange(
webrtc::PeerConnectionInterface::SignalingState new_state) override;
- virtual void OnAddStream(webrtc::MediaStreamInterface* stream) override;
- virtual void OnRemoveStream(webrtc::MediaStreamInterface* stream) override;
- virtual void OnIceCandidate(
- const webrtc::IceCandidateInterface* candidate) override;
- virtual void OnIceConnectionChange(
+ void OnAddStream(webrtc::MediaStreamInterface* stream) override;
+ void OnRemoveStream(webrtc::MediaStreamInterface* stream) override;
+ void OnIceCandidate(const webrtc::IceCandidateInterface* candidate) override;
+ void OnIceConnectionChange(
webrtc::PeerConnectionInterface::IceConnectionState new_state) override;
- virtual void OnIceGatheringChange(
+ void OnIceGatheringChange(
webrtc::PeerConnectionInterface::IceGatheringState new_state) override;
- virtual void OnDataChannel(
- webrtc::DataChannelInterface* data_channel) override;
- virtual void OnRenegotiationNeeded() override;
+ void OnDataChannel(webrtc::DataChannelInterface* data_channel) override;
+ void OnRenegotiationNeeded() override;
// Delegate functions to allow for mocking of WebKit interfaces.
// getStats takes ownership of request parameter.
« no previous file with comments | « content/renderer/media/rtc_media_constraints.h ('k') | content/renderer/media/rtc_peer_connection_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698