Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: content/renderer/dom_storage/dom_storage_dispatcher.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/dom_storage/dom_storage_dispatcher.cc
diff --git a/content/renderer/dom_storage/dom_storage_dispatcher.cc b/content/renderer/dom_storage/dom_storage_dispatcher.cc
index 6d4496632bb1afe8c741dcab453ef7b875145f61..94332709d4009b129f3ceebd8faab8815f0e24d0 100644
--- a/content/renderer/dom_storage/dom_storage_dispatcher.cc
+++ b/content/renderer/dom_storage/dom_storage_dispatcher.cc
@@ -39,9 +39,9 @@ class MessageThrottlingFilter : public IPC::MessageFilter {
void Shutdown() { sender_ = NULL; }
private:
- virtual ~MessageThrottlingFilter() {}
+ ~MessageThrottlingFilter() override {}
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& message) override;
int GetPendingCount() { return IncrementPendingCountN(0); }
int IncrementPendingCount() { return IncrementPendingCountN(1); }
@@ -109,20 +109,25 @@ class DomStorageDispatcher::ProxyImpl : public DOMStorageProxy {
void Shutdown();
// DOMStorageProxy interface for use by DOMStorageCachedArea.
- virtual void LoadArea(int connection_id, DOMStorageValuesMap* values,
- bool* send_log_get_messages,
- const CompletionCallback& callback) override;
- virtual void SetItem(int connection_id, const base::string16& key,
- const base::string16& value, const GURL& page_url,
- const CompletionCallback& callback) override;
- virtual void LogGetItem(int connection_id, const base::string16& key,
- const base::NullableString16& value) override;
- virtual void RemoveItem(int connection_id, const base::string16& key,
- const GURL& page_url,
- const CompletionCallback& callback) override;
- virtual void ClearArea(int connection_id,
- const GURL& page_url,
- const CompletionCallback& callback) override;
+ void LoadArea(int connection_id,
+ DOMStorageValuesMap* values,
+ bool* send_log_get_messages,
+ const CompletionCallback& callback) override;
+ void SetItem(int connection_id,
+ const base::string16& key,
+ const base::string16& value,
+ const GURL& page_url,
+ const CompletionCallback& callback) override;
+ void LogGetItem(int connection_id,
+ const base::string16& key,
+ const base::NullableString16& value) override;
+ void RemoveItem(int connection_id,
+ const base::string16& key,
+ const GURL& page_url,
+ const CompletionCallback& callback) override;
+ void ClearArea(int connection_id,
+ const GURL& page_url,
+ const CompletionCallback& callback) override;
private:
// Struct to hold references to our contained areas and
@@ -139,8 +144,7 @@ class DomStorageDispatcher::ProxyImpl : public DOMStorageProxy {
typedef std::map<std::string, CachedAreaHolder> CachedAreaMap;
typedef std::list<CompletionCallback> CallbackList;
- virtual ~ProxyImpl() {
- }
+ ~ProxyImpl() override {}
// Sudden termination is disabled when there are callbacks pending
// to more reliably commit changes during shutdown.
« no previous file with comments | « content/renderer/dom_storage/dom_storage_cached_area_unittest.cc ('k') | content/renderer/external_popup_menu_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698