content/renderer/external_popup_menu_browsertest.cc - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/external_popup_menu_browsertest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/external_popup_menu_browsertest.cc

diff --git a/content/renderer/external_popup_menu_browsertest.cc b/content/renderer/external_popup_menu_browsertest.cc

index e23573dcfc0ef93ac672cbfa5cb1e51ca486b82d..cadb51ffda6b52152bb959fedb7521882984f7e6 100644

--- a/content/renderer/external_popup_menu_browsertest.cc

+++ b/content/renderer/external_popup_menu_browsertest.cc

@@ -133,7 +133,7 @@ class ExternalPopupMenuRemoveTest : public ExternalPopupMenuTest {

ExternalPopupMenuRemoveTest() {}

protected:

- virtual bool ShouldRemoveSelectOnChange() const override { return true; }

+ bool ShouldRemoveSelectOnChange() const override { return true; }

};

// Tests that nothing bad happen when the page removes the select when it

« no previous file with comments | « content/renderer/dom_storage/dom_storage_dispatcher.cc ('k') | content/renderer/fetchers/resource_fetcher_impl.h » ('j') | no next file with comments »