Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Unified Diff: content/renderer/dom_storage/dom_storage_cached_area_unittest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/dom_storage/dom_storage_cached_area_unittest.cc
diff --git a/content/renderer/dom_storage/dom_storage_cached_area_unittest.cc b/content/renderer/dom_storage/dom_storage_cached_area_unittest.cc
index 39b1eb76a2f6feab1b7ebc75087eb736413e1ef4..74294587c5bfe63f5c7986ffa7d47292c9db8a83 100644
--- a/content/renderer/dom_storage/dom_storage_cached_area_unittest.cc
+++ b/content/renderer/dom_storage/dom_storage_cached_area_unittest.cc
@@ -23,10 +23,10 @@ class MockProxy : public DOMStorageProxy {
// DOMStorageProxy interface for use by DOMStorageCachedArea.
- virtual void LoadArea(int connection_id,
- DOMStorageValuesMap* values,
- bool* send_log_get_messages,
- const CompletionCallback& callback) override {
+ void LoadArea(int connection_id,
+ DOMStorageValuesMap* values,
+ bool* send_log_get_messages,
+ const CompletionCallback& callback) override {
pending_callbacks_.push_back(callback);
observed_load_area_ = true;
observed_connection_id_ = connection_id;
@@ -34,11 +34,11 @@ class MockProxy : public DOMStorageProxy {
*send_log_get_messages = false;
}
- virtual void SetItem(int connection_id,
- const base::string16& key,
- const base::string16& value,
- const GURL& page_url,
- const CompletionCallback& callback) override {
+ void SetItem(int connection_id,
+ const base::string16& key,
+ const base::string16& value,
+ const GURL& page_url,
+ const CompletionCallback& callback) override {
pending_callbacks_.push_back(callback);
observed_set_item_ = true;
observed_connection_id_ = connection_id;
@@ -47,15 +47,14 @@ class MockProxy : public DOMStorageProxy {
observed_page_url_ = page_url;
}
- virtual void LogGetItem(int connection_id,
- const base::string16& key,
- const base::NullableString16& value) override {
- }
+ void LogGetItem(int connection_id,
+ const base::string16& key,
+ const base::NullableString16& value) override {}
- virtual void RemoveItem(int connection_id,
- const base::string16& key,
- const GURL& page_url,
- const CompletionCallback& callback) override {
+ void RemoveItem(int connection_id,
+ const base::string16& key,
+ const GURL& page_url,
+ const CompletionCallback& callback) override {
pending_callbacks_.push_back(callback);
observed_remove_item_ = true;
observed_connection_id_ = connection_id;
@@ -63,9 +62,9 @@ class MockProxy : public DOMStorageProxy {
observed_page_url_ = page_url;
}
- virtual void ClearArea(int connection_id,
- const GURL& page_url,
- const CompletionCallback& callback) override {
+ void ClearArea(int connection_id,
+ const GURL& page_url,
+ const CompletionCallback& callback) override {
pending_callbacks_.push_back(callback);
observed_clear_area_ = true;
observed_connection_id_ = connection_id;
@@ -110,7 +109,7 @@ class MockProxy : public DOMStorageProxy {
GURL observed_page_url_;
private:
- virtual ~MockProxy() {}
+ ~MockProxy() override {}
};
} // namespace
« no previous file with comments | « content/renderer/dom_serializer_browsertest.cc ('k') | content/renderer/dom_storage/dom_storage_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698