content/renderer/dom_serializer_browsertest.cc - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/dom_serializer_browsertest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/dom_automation_controller.h ('k') | content/renderer/dom_storage/dom_storage_cached_area_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/dom_serializer_browsertest.cc

diff --git a/content/renderer/dom_serializer_browsertest.cc b/content/renderer/dom_serializer_browsertest.cc

index cdce1d66a31dbbcf68b8f5ec3bfb78c61f67a76b..7b885f8870ea34cc2601376195751f94dcbe8ff4 100644

--- a/content/renderer/dom_serializer_browsertest.cc

+++ b/content/renderer/dom_serializer_browsertest.cc

@@ -155,7 +155,7 @@ class LoadObserver : public RenderViewObserver {

: RenderViewObserver(render_view),

quit_closure_(quit_closure) {}

- virtual void DidFinishLoad(blink::WebLocalFrame* frame) override {

+ void DidFinishLoad(blink::WebLocalFrame* frame) override {

if (frame == render_view()->GetWebView()->mainFrame())

quit_closure_.Run();

}

@@ -171,7 +171,7 @@ class DomSerializerTests : public ContentBrowserTest,

: serialized_(false),

local_directory_name_(FILE_PATH_LITERAL("./dummy_files/")) {}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

command_line->AppendSwitch(switches::kSingleProcess);

#if defined(OS_WIN)

// Don't want to try to create a GPU process.

« no previous file with comments | « content/renderer/dom_automation_controller.h ('k') | content/renderer/dom_storage/dom_storage_cached_area_unittest.cc » ('j') | no next file with comments »