content/renderer/dom_automation_controller.h - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/dom_automation_controller.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/dom_automation_controller.h

diff --git a/content/renderer/dom_automation_controller.h b/content/renderer/dom_automation_controller.h

index cefb5100dba627ea5504fc26fb18bd09a2e8f3f5..29b1db372991778416e662475e6d0b271357a27f 100644

--- a/content/renderer/dom_automation_controller.h

+++ b/content/renderer/dom_automation_controller.h

@@ -107,14 +107,14 @@ class DomAutomationController : public gin::Wrappable<DomAutomationController>,

private:

explicit DomAutomationController(RenderFrame* render_view);

- virtual ~DomAutomationController();

+ ~DomAutomationController() override;

// gin::WrappableBase

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

// RenderViewObserver

- virtual void OnDestruct() override;

+ void OnDestruct() override;

int automation_id_; // routing id to be used by the next channel.

« no previous file with comments | « content/renderer/devtools/devtools_agent_filter.h ('k') | content/renderer/dom_serializer_browsertest.cc » ('j') | no next file with comments »