Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 670173002: Fix webrequest api for webview in webui (Closed)

Created:
6 years, 2 months ago by guohui
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Roger Tawa OOO till Jul 10th, xiyuan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix webrequest api for webview in webui <webview> can be directly embedded in a whitelisted webui page, but some webview apis are broken in a extension-less webui context. This CL fixes: 1. a crash on adding webview.request listener due to null extension pointer. 2. a crash on navigating away from a webview embedder due to dangling zoom observer. BUG=426016 Committed: https://crrev.com/02ca72f2a3d4ad3e5c3142a1be013b49de12b155 Cr-Commit-Position: refs/heads/master@{#300897}

Patch Set 1 #

Total comments: 8

Patch Set 2 : extension id fixed in callers #

Total comments: 2

Patch Set 3 : rename EmbedderDestroyed to EmbedderWillBeDestroyed #

Total comments: 2

Patch Set 4 : nits fixed #

Patch Set 5 : scoped_refptr not testable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -28 lines) Patch
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.h View 1 4 chunks +16 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 6 chunks +9 lines, -8 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M extensions/browser/extension_function.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 1 2 2 chunks +11 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
guohui
Hey fady and kalman, could you please review the CL? Thanks, Hui
6 years, 2 months ago (2014-10-22 15:29:28 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/670173002/diff/1/extensions/browser/extension_function.h File extensions/browser/extension_function.h (right): https://codereview.chromium.org/670173002/diff/1/extensions/browser/extension_function.h#newcode223 extensions/browser/extension_function.h:223: return extension_ ? extension_->id() : base::EmptyString(); I actually deliberately ...
6 years, 2 months ago (2014-10-22 15:36:15 UTC) #3
Fady Samuel
https://codereview.chromium.org/670173002/diff/1/extensions/browser/guest_view/guest_view_base.cc File extensions/browser/guest_view/guest_view_base.cc (right): https://codereview.chromium.org/670173002/diff/1/extensions/browser/guest_view/guest_view_base.cc#newcode81 extensions/browser/guest_view/guest_view_base.cc:81: guest_->WillDetachFromEmbedder(); I think guest_->EmbedderDestroyed() already does what you need. ...
6 years, 2 months ago (2014-10-22 16:43:21 UTC) #4
guohui
https://codereview.chromium.org/670173002/diff/1/extensions/browser/extension_function.h File extensions/browser/extension_function.h (right): https://codereview.chromium.org/670173002/diff/1/extensions/browser/extension_function.h#newcode223 extensions/browser/extension_function.h:223: return extension_ ? extension_->id() : base::EmptyString(); On 2014/10/22 15:36:15, ...
6 years, 2 months ago (2014-10-22 18:46:07 UTC) #5
Fady Samuel
On 2014/10/22 18:46:07, guohui wrote: > https://codereview.chromium.org/670173002/diff/1/extensions/browser/extension_function.h > File extensions/browser/extension_function.h (right): > > https://codereview.chromium.org/670173002/diff/1/extensions/browser/extension_function.h#newcode223 > ...
6 years, 2 months ago (2014-10-22 18:53:44 UTC) #6
not at google - send to devlin
https://codereview.chromium.org/670173002/diff/20001/extensions/browser/extension_function_dispatcher.cc File extensions/browser/extension_function_dispatcher.cc (right): https://codereview.chromium.org/670173002/diff/20001/extensions/browser/extension_function_dispatcher.cc#newcode259 extensions/browser/extension_function_dispatcher.cc:259: if (!extension_id.empty()) { This isn't the same as the ...
6 years, 2 months ago (2014-10-22 19:12:06 UTC) #7
guohui
merged EmbedderDestroyed and WillDetachFromDembedder into one. https://codereview.chromium.org/670173002/diff/20001/extensions/browser/extension_function_dispatcher.cc File extensions/browser/extension_function_dispatcher.cc (right): https://codereview.chromium.org/670173002/diff/20001/extensions/browser/extension_function_dispatcher.cc#newcode259 extensions/browser/extension_function_dispatcher.cc:259: if (!extension_id.empty()) { ...
6 years, 2 months ago (2014-10-22 19:53:47 UTC) #11
not at google - send to devlin
lgtm
6 years, 2 months ago (2014-10-22 19:57:36 UTC) #12
Fady Samuel
guest_view lgtm + nit. https://codereview.chromium.org/670173002/diff/90001/extensions/browser/guest_view/guest_view_base.cc File extensions/browser/guest_view/guest_view_base.cc (left): https://codereview.chromium.org/670173002/diff/90001/extensions/browser/guest_view/guest_view_base.cc#oldcode95 extensions/browser/guest_view/guest_view_base.cc:95: guest_->embedder_web_contents_ = NULL; Super nit: ...
6 years, 2 months ago (2014-10-22 21:20:53 UTC) #13
guohui
https://codereview.chromium.org/670173002/diff/90001/extensions/browser/guest_view/guest_view_base.cc File extensions/browser/guest_view/guest_view_base.cc (left): https://codereview.chromium.org/670173002/diff/90001/extensions/browser/guest_view/guest_view_base.cc#oldcode95 extensions/browser/guest_view/guest_view_base.cc:95: guest_->embedder_web_contents_ = NULL; On 2014/10/22 21:20:53, Fady Samuel wrote: ...
6 years, 2 months ago (2014-10-23 13:40:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670173002/110001
6 years, 2 months ago (2014-10-23 13:42:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/27285)
6 years, 2 months ago (2014-10-23 13:51:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670173002/130001
6 years, 2 months ago (2014-10-23 14:04:26 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:130001)
6 years, 2 months ago (2014-10-23 16:06:55 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 16:07:54 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/02ca72f2a3d4ad3e5c3142a1be013b49de12b155
Cr-Commit-Position: refs/heads/master@{#300897}

Powered by Google App Engine
This is Rietveld 408576698