Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 670173002: Fix webrequest api for webview in webui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scoped_refptr not testable Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.h
diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h
index e8b0fa80401a9de4e257fba23d1881f1ba4dc400..5a176a4ab560fd681d1072e600c5165ff06c5b1f 100644
--- a/extensions/browser/guest_view/guest_view_base.h
+++ b/extensions/browser/guest_view/guest_view_base.h
@@ -87,12 +87,11 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
// completed loading.
virtual void DidStopLoading() {}
- // This method is called when the guest's embedder WebContents has been
- // destroyed and the guest will be destroyed shortly.
- //
- // This gives the derived class an opportunity to perform some cleanup prior
- // to destruction.
- virtual void EmbedderDestroyed() {}
+ // This method is called before the embedder is destroyed.
+ // |embedder_web_contents_| should still be valid during this call. This
+ // allows the derived class to perform some cleanup related to the embedder
+ // web contents.
+ virtual void EmbedderWillBeDestroyed() {}
// This method is called when the guest WebContents has been destroyed. This
// object will be destroyed after this call returns.
« no previous file with comments | « extensions/browser/extension_function_dispatcher.cc ('k') | extensions/browser/guest_view/guest_view_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698