extensions/browser/guest_view/web_view/web_view_guest.cc - Issue 670173002: Fix webrequest api for webview in webui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 670173002: Fix webrequest api for webview in webui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scoped_refptr not testable Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_guest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc

index ab95833d07e735f52fd02269e22b5069a9b22f02..02e7fb2e100a17b513b6ac036f46de4c7042a1f1 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc

@@ -349,7 +349,10 @@ void WebViewGuest::DidStopLoading() {

new GuestViewBase::Event(webview::kEventLoadStop, args.Pass()));

}

-void WebViewGuest::EmbedderDestroyed() {

+void WebViewGuest::EmbedderWillBeDestroyed() {

+ if (web_view_guest_delegate_)

+ web_view_guest_delegate_->OnEmbedderWillBeDestroyed();

content::BrowserThread::PostTask(

content::BrowserThread::IO,

FROM_HERE,