Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 669943003: shell_util: AddFileAssociations now correctly quotes "%1" arguments. (Closed)

Created:
6 years, 1 month ago by Matt Giuca
Modified:
6 years, 1 month ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

shell_util: AddFileAssociations now correctly quotes "%1" arguments. Instead of GetCommandLineString, uses GetCommandLineStringWithPlaceholders, which is specially designed to quote placeholder arguments like "%1". This is necessary when writing a command line to the Windows registry, because otherwise Windows may put a filename with a space in it, and recognise it as two separate arguments. BUG=130455 Committed: https://crrev.com/b45fe1fab91262985cb4836add4b3feb873364e8 Cr-Commit-Position: refs/heads/master@{#301114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
This was a mistake in my previous CL (https://codereview.chromium.org/487693002) -- I wrote GetCommandLineStringWithPlaceholders for this ...
6 years, 1 month ago (2014-10-24 06:36:02 UTC) #2
grt (UTC plus 2)
lgtm
6 years, 1 month ago (2014-10-24 15:20:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669943003/1
6 years, 1 month ago (2014-10-24 15:21:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-24 16:08:45 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 16:09:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b45fe1fab91262985cb4836add4b3feb873364e8
Cr-Commit-Position: refs/heads/master@{#301114}

Powered by Google App Engine
This is Rietveld 408576698