chrome/installer/util/shell_util.cc - Issue 669943003: shell_util: AddFileAssociations now correctly quotes "%1" arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/shell_util.cc

Issue 669943003: shell_util: AddFileAssociations now correctly quotes "%1" arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/shell_util.cc

diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc

index cf901ba5f2f1984db042f644b790ffae59e95f5e..fd1a6c35d1f328603487641476e10f2d7f2fecae 100644

--- a/chrome/installer/util/shell_util.cc

+++ b/chrome/installer/util/shell_util.cc

@@ -2445,7 +2445,7 @@ bool ShellUtil::AddFileAssociations(

app_info.file_type_name = file_type_name;

app_info.file_type_icon_path = icon_path.value();

app_info.file_type_icon_index = 0;

- app_info.command_line = command_line.GetCommandLineString();

+ app_info.command_line = command_line.GetCommandLineStringWithPlaceholders();

RegistryEntry::GetProgIdEntries(app_info, &entries);

// Associate each extension that the app can handle with the class. Set this

« no previous file with comments | « no previous file | chrome/installer/util/shell_util_unittest.cc » ('j') | no next file with comments »