shell_util: AddFileAssociations now correctly quotes "%1" arguments.

chrome/installer/util/shell_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/shell_util.h"
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/base_paths_win.h"
@@ skipping 807 matching lines @@
     base::win::RegKey key;
     ASSERT_EQ(
         ERROR_SUCCESS,
         key.Create(
             HKEY_CURRENT_USER, L"Software\\Classes\\.test2", KEY_ALL_ACCESS));
     EXPECT_EQ(ERROR_SUCCESS, key.WriteValue(L"", L"SomeOtherApp"));
   }
 
   static base::CommandLine OpenCommand() {
     base::FilePath open_command_path(kTestOpenCommand);
-    return base::CommandLine(open_command_path);
+    base::CommandLine open_command(open_command_path);
+    // The "%1" should automatically be quoted.
+    open_command.AppendArg("%1");
+    return open_command;
   }
 
   static std::set<base::string16> FileExtensions() {
     std::set<base::string16> file_extensions;
     for (size_t i = 0; i < arraysize(kTestFileExtensions); ++i)
       file_extensions.insert(kTestFileExtensions[i]);
     return file_extensions;
   }
 
  private:
@@ skipping 22 matching lines @@
             key.Open(HKEY_CURRENT_USER,
                      L"Software\\Classes\\TestApp\\DefaultIcon",
                      KEY_READ));
   EXPECT_EQ(ERROR_SUCCESS, key.ReadValue(L"", &value));
   EXPECT_EQ(L"D:\\test.ico,0", value);
   ASSERT_EQ(ERROR_SUCCESS,
             key.Open(HKEY_CURRENT_USER,
                      L"Software\\Classes\\TestApp\\shell\\open\\command",
                      KEY_READ));
   EXPECT_EQ(ERROR_SUCCESS, key.ReadValue(L"", &value));
-  EXPECT_EQ(L"\"C:\\test.exe\"", value);
+  EXPECT_EQ(L"\"C:\\test.exe\" \"%1\"", value);
 
   // .test1 should be default-associated with our test app.
   ASSERT_EQ(
       ERROR_SUCCESS,
       key.Open(HKEY_CURRENT_USER, L"Software\\Classes\\.test1", KEY_READ));
   EXPECT_EQ(ERROR_SUCCESS, key.ReadValue(L"", &value));
   EXPECT_EQ(L"TestApp", value);
   ASSERT_EQ(ERROR_SUCCESS,
             key.Open(HKEY_CURRENT_USER,
                      L"Software\\Classes\\.test1\\OpenWithProgids",
@@ skipping 118 matching lines @@
 
   const base::string16 expected[] = { L"", L"MY", L"MZXQ", L"MZXW6", L"MZXW6YQ",
                                 L"MZXW6YTB", L"MZXW6YTBOI"};
 
   // Run the tests, with one more letter in the input every pass.
   for (int i = 0; i < arraysize(expected); ++i) {
     ASSERT_EQ(expected[i],
               ShellUtil::ByteArrayToBase32(test_array, i));
   }
 }