Most references to GetActiveEntry removed from chrome/browser/ui.

chrome/browser/ui/search/search_tab_helper.cc

Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index f9dc05ab7aa66c532cda80c252c5574a2a9a96fd..255f211842eda1c5746089b3f8017cf4554a9fb8 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -69,7 +69,7 @@ void RecordCacheableNTPLoadHistogram(bool succeeded) {
 
 bool IsCacheableNTP(const content::WebContents* contents) {
   const content::NavigationEntry* entry =
-      contents->GetController().GetActiveEntry();
+      contents->GetController().GetLastCommittedEntry();

[Charlie Reis, 2013/11/12 01:09:29]

@sreeram: I see you specifically used GetVisibleEntry below in
http://crrev.com/182381.  Should this be using it as well?

[sreeram, 2013/11/12 09:01:26]

Based on the call sites below (i.e., where IsCacheableNTP() is called), it seems
to me that GetLastCommittedEntry() is correct. No need for GetVisibleEntry()
here.

[jww, 2013/11/12 22:32:50]

Done.

   return chrome::ShouldUseCacheableNTP() &&
       chrome::NavEntryIsInstantNTP(contents, entry) &&
       entry->GetURL() != GURL(chrome::kChromeSearchLocalNtpUrl);
@@ -304,7 +304,7 @@ void SearchTabHelper::DidNavigateMainFrame(
   // also a race condition between this code and the page's SetTitle call which
   // this rule avoids.
   content::NavigationEntry* entry =
-      web_contents_->GetController().GetActiveEntry();
+      web_contents_->GetController().GetLastCommittedEntry();

[samarth, 2013/11/12 15:55:07]

Just to confirm, this will be the entry that "triggered" the call to
DidNavigateMainFrame?  The same question applies for the usage in
IsCacheableNTP.

[jww, 2013/11/12 22:32:50]

creis should confirm, but yes.

[Charlie Reis, 2013/11/13 18:40:03]

Yes, this is the entry that just committed as part of the DidNavigateMainFrame. 
There shouldn't be any way for it to change before we get here.

   if (entry && entry->GetTitle().empty() &&
       (entry->GetVirtualURL() == GURL(chrome::kChromeUINewTabURL) ||
        chrome::NavEntryIsInstantNTP(web_contents_, entry))) {