Most references to GetActiveEntry removed from chrome/browser/ui.

chrome/browser/ui/search/instant_controller.cc

Index: chrome/browser/ui/search/instant_controller.cc
diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc
index 526c3b39a89e9dad3e97f3cc6004f31321b92015..a7477ad43d389d07dc2d23ad72a721115436eaf3 100644
--- a/chrome/browser/ui/search/instant_controller.cc
+++ b/chrome/browser/ui/search/instant_controller.cc
@@ -61,11 +61,11 @@ void EnsureSearchTermsAreSet(content::WebContents* contents,
       controller->GetTransientEntry())
     return;
 
-  const content::NavigationEntry* active_entry = controller->GetActiveEntry();
+  const content::NavigationEntry* entry = controller->GetLastCommittedEntry();

[Charlie Reis, 2013/11/12 01:09:29]

@samarth: I'm not sure which entry you're looking for here.  Suppose there's a
slow pending entry, which may or may not have its URL visible to the user (e.g.,
depending on some checks for URL spoofs).  Does this code need the URL from the
omnibox, the URL of the last committed page, or the URL of the actual pending
entry, regardless of whether it's visible in the omnibox or not?

[samarth, 2013/11/12 15:55:07]

What's important here is the fact that we set the search terms on the transient
entry using SetExtraData, not the actual URL.   Given that, using the last
committed entry seems safer (since if InstantTab is set, then that should be a
search url).

Note to self: I should revisit this function to make sure this is actually still
necessary.

[jww, 2013/11/12 22:32:50]

Done.

   content::NavigationEntry* transient = controller->CreateNavigationEntry(
-      active_entry->GetURL(),
-      active_entry->GetReferrer(),
-      active_entry->GetTransitionType(),
+      entry->GetURL(),
+      entry->GetReferrer(),
+      entry->GetTransitionType(),
       false,
       std::string(),
       contents->GetBrowserContext());