chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h - Issue 66993003: Most references to GetActiveEntry removed from chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h

Issue 66993003: Most references to GetActiveEntry removed from chrome/browser/ui. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates from nasko comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h

diff --git a/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h b/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h

index 5525f1682b368116a3de267f9ee95450fa7862dc..5df64f492422a1e224743c5319ca9a44fff10c56 100644

--- a/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h

+++ b/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h

@@ -31,6 +31,9 @@ class TabContentsSyncedTabDelegate

virtual int GetPendingEntryIndex() const OVERRIDE;

virtual content::NavigationEntry* GetPendingEntry() const OVERRIDE;

virtual content::NavigationEntry* GetEntryAtIndex(int i) const OVERRIDE;

+ // TODO(jww): This needs to be split into GetVisibleEntry and

+ // GetLastCommittedEntry, but that requires modifying the parent class,

+ // SyncedTabDelegate, first.

virtual content::NavigationEntry* GetActiveEntry() const OVERRIDE;

virtual bool ProfileIsManaged() const OVERRIDE;

virtual const std::vector<const content::NavigationEntry*>*