Most references to GetActiveEntry removed from chrome/browser/ui.

chrome/browser/ui/cocoa/applescript/tab_applescript.mm

Index: chrome/browser/ui/cocoa/applescript/tab_applescript.mm
diff --git a/chrome/browser/ui/cocoa/applescript/tab_applescript.mm b/chrome/browser/ui/cocoa/applescript/tab_applescript.mm
index a8afbb87f7add57287e2c0b4f19d0bfe7afb5547..593a5f5638fe25eb184c7b0cb698697b27132690 100644
--- a/chrome/browser/ui/cocoa/applescript/tab_applescript.mm
+++ b/chrome/browser/ui/cocoa/applescript/tab_applescript.mm
@@ -113,7 +113,8 @@ void ResumeAppleEventAndSendReply(NSAppleEventManagerSuspensionID suspension_id,
     return nil;
   }
 
-  NavigationEntry* entry = webContents_->GetController().GetActiveEntry();
+  NavigationEntry* entry =
+      webContents_->GetController().GetLastCommittedEntry();

[Charlie Reis, 2013/11/12 01:09:29]

@pinkerton:
My Cocoa skills are a bit rusty (or nonexistent), but this looks like it's in a
method to get "the URL" of a tab from AppleScript.  That would be the pending
URL if a slow navigation were in progress, correct?  That means we should use
GetVisibleEntry here.

[pink (ping after 24hrs), 2013/11/12 15:27:32]

Sounds right, though my memory of NavigationController is fleeting at best.

[jww, 2013/11/12 22:32:50]

Done.

   if (!entry) {
     return nil;
   }
@@ -136,7 +137,8 @@ void ResumeAppleEventAndSendReply(NSAppleEventManagerSuspensionID suspension_id,
     return;
   }
 
-  NavigationEntry* entry = webContents_->GetController().GetActiveEntry();
+  NavigationEntry* entry =
+      webContents_->GetController().GetLastCommittedEntry();

[Charlie Reis, 2013/11/12 01:09:29]

This looks correct, since we're trying to get the previousURL from it.

[pink (ping after 24hrs), 2013/11/12 15:27:32]

agreed.

[jww, 2013/11/12 22:32:50]

Done.

   if (!entry)
     return;
 
@@ -150,7 +152,8 @@ void ResumeAppleEventAndSendReply(NSAppleEventManagerSuspensionID suspension_id,
 }
 
 - (NSString*)title {
-  NavigationEntry* entry = webContents_->GetController().GetActiveEntry();
+  NavigationEntry* entry =
+      webContents_->GetController().GetLastCommittedEntry();

[Charlie Reis, 2013/11/12 01:09:29]

This should almost certainly be GetVisibleEntry, since it's the title that the
user sees.

[pink (ping after 24hrs), 2013/11/12 15:27:32]

Sounds right, same caveat as above.

[jww, 2013/11/12 22:32:50]

Done.

   if (!entry)
     return nil;