Most references to GetActiveEntry removed from chrome/browser/ui.

chrome/browser/ui/cocoa/applescript/tab_applescript.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/applescript/tab_applescript.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #import "base/mac/scoped_nsobject.h"
@@ skipping 95 matching lines @@
 
   if ([self tempURL])
     [self setURL:[self tempURL]];
 }
 
 - (NSString*)URL {
   if (!webContents_) {
     return nil;
   }
 
-  NavigationEntry* entry = webContents_->GetController().GetActiveEntry();
+  NavigationEntry* entry =
+      webContents_->GetController().GetLastCommittedEntry();

[Charlie Reis, 2013/11/12 01:09:29]

@pinkerton:
My Cocoa skills are a bit rusty (or nonexistent), but this looks like it's in a
method to get "the URL" of a tab from AppleScript.  That would be the pending
URL if a slow navigation were in progress, correct?  That means we should use
GetVisibleEntry here.

[pink (ping after 24hrs), 2013/11/12 15:27:32]

Sounds right, though my memory of NavigationController is fleeting at best.

[jww, 2013/11/12 22:32:50]

Done.

   if (!entry) {
     return nil;
   }
   const GURL& url = entry->GetVirtualURL();
   return base::SysUTF8ToNSString(url.spec());
 }
 
 - (void)setURL:(NSString*)aURL {
   // If a scripter sets a URL before the node is added save it at a temporary
   // location.
   if (!webContents_) {
     [self setTempURL:aURL];
     return;
   }
 
   GURL url(base::SysNSStringToUTF8(aURL));
   // check for valid url.
   if (!url.is_empty() && !url.is_valid()) {
     AppleScript::SetError(AppleScript::errInvalidURL);
     return;
   }
 
-  NavigationEntry* entry = webContents_->GetController().GetActiveEntry();
+  NavigationEntry* entry =
+      webContents_->GetController().GetLastCommittedEntry();

[Charlie Reis, 2013/11/12 01:09:29]

This looks correct, since we're trying to get the previousURL from it.

[pink (ping after 24hrs), 2013/11/12 15:27:32]

agreed.

[jww, 2013/11/12 22:32:50]

Done.

   if (!entry)
     return;
 
   const GURL& previousURL = entry->GetVirtualURL();
   webContents_->OpenURL(OpenURLParams(
       url,
       content::Referrer(previousURL, blink::WebReferrerPolicyDefault),
       CURRENT_TAB,
       content::PAGE_TRANSITION_TYPED,
       false));
 }
 
 - (NSString*)title {
-  NavigationEntry* entry = webContents_->GetController().GetActiveEntry();
+  NavigationEntry* entry =
+      webContents_->GetController().GetLastCommittedEntry();

[Charlie Reis, 2013/11/12 01:09:29]

This should almost certainly be GetVisibleEntry, since it's the title that the
user sees.

[pink (ping after 24hrs), 2013/11/12 15:27:32]

Sounds right, same caveat as above.

[jww, 2013/11/12 22:32:50]

Done.

   if (!entry)
     return nil;
 
   string16 title = entry ? entry->GetTitle() : string16();
   return base::SysUTF16ToNSString(title);
 }
 
 - (NSNumber*)loading {
   BOOL loadingValue = webContents_->IsLoading() ? YES : NO;
   return [NSNumber numberWithBool:loadingValue];
@@ skipping 166 matching lines @@
   string16 script = base::SysNSStringToUTF16(
       [[command evaluatedArguments] objectForKey:@"javascript"]);
   view->ExecuteJavascriptInWebFrameCallbackResult(string16(),  // frame_xpath
                                                   script,
                                                   callback);
 
   return nil;
 }
 
 @end