Relocate markForLayoutAndParentResourceInvalidation

Relocate markForLayoutAndParentResourceInvalidation

To facilitate repurposing of RenderSVGResource for paint-server use,
move RenderSVGResource::markForLayoutAndParentResourceInvalidation
to RenderSVGResourceContainer.

For reduced dependencies call through a method with the same name on
SVGElement.

BUG=420022
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184258

[fs, 2014-10-22 15:08:55]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org, schenney@chromium.org

[fs, 2014-10-22 15:08:56]

Uploaded this incrementally because the changes in PS2 may not be valuable
enough to keep. (PS2 reduces the dependencies and [hopefully] is slightly more
obvious than that long-winded name in the subject =))

https://codereview.chromium.org/669153002/diff/20001/Source/core/svg/SVGEleme...
File Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/669153002/diff/20001/Source/core/svg/SVGEleme...
Source/core/svg/SVGElement.cpp:966: // FIXME: Hoist
setNeedsLayoutAndFullPaintInvalidation out of thw below.
Oops, had intended to remove this... Will do that if PS2 is ok'd.

[pdr., 2014-10-22 17:42:12]

LGTM with two nits.

@fmalita, could you take a peek at this as well?

https://codereview.chromium.org/669153002/diff/40001/Source/core/svg/SVGForei...
File Source/core/svg/SVGForeignObjectElement.cpp (right):

https://codereview.chromium.org/669153002/diff/40001/Source/core/svg/SVGForei...
Source/core/svg/SVGForeignObjectElement.cpp:113: boundsChanged(renderer);
Can we move this under the isLengthAttribute conditional?

if (isLengthAttribute) {
    updateRelativeLengthsInformation();
    if (RenderObject* renderer = this->renderer())
        boundsChanged(renderer);
}

https://codereview.chromium.org/669153002/diff/40001/Source/core/svg/SVGGraph...
File Source/core/svg/SVGGraphicsElement.h (right):

https://codereview.chromium.org/669153002/diff/40001/Source/core/svg/SVGGraph...
Source/core/svg/SVGGraphicsElement.h:81: static void
boundsChanged(RenderObject*);
I don't understand the advantage of this over just calling
markForLayoutAndParentResourceInvalidation directly.

[f(malita), 2014-10-22 19:13:22]

lgtm % nits(pdr)

[fs, 2014-10-23 09:15:29]

https://codereview.chromium.org/669153002/diff/40001/Source/core/svg/SVGForei...
File Source/core/svg/SVGForeignObjectElement.cpp (right):

https://codereview.chromium.org/669153002/diff/40001/Source/core/svg/SVGForei...
Source/core/svg/SVGForeignObjectElement.cpp:113: boundsChanged(renderer);
On 2014/10/22 17:42:12, pdr wrote:
> Can we move this under the isLengthAttribute conditional?
> 
> if (isLengthAttribute) {
>     updateRelativeLengthsInformation();
>     if (RenderObject* renderer = this->renderer())
>         boundsChanged(renderer);
> }

Done.

https://codereview.chromium.org/669153002/diff/40001/Source/core/svg/SVGGraph...
File Source/core/svg/SVGGraphicsElement.h (right):

https://codereview.chromium.org/669153002/diff/40001/Source/core/svg/SVGGraph...
Source/core/svg/SVGGraphicsElement.h:81: static void
boundsChanged(RenderObject*);
On 2014/10/22 17:42:12, pdr wrote:
> I don't understand the advantage of this over just calling
> markForLayoutAndParentResourceInvalidation directly.

Nothing really, I was toying around/probing the space a bit with/for
finer-grained invalidations, and then this read more easily (and obviously).
I'll drop it back to markForLayout... (oh, why did I squash those commits...).

[fs, 2014-10-23 10:28:10]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-10-23 10:28:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669153002/60001

[commit-bot: I haz the power, 2014-10-23 12:14:26]

Committed patchset #4 (id:60001) as 184258