Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: Source/core/rendering/svg/SVGResourcesCache.cpp

Issue 669153002: Relocate markForLayoutAndParentResourceInvalidation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Drop boundsChanged. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 128
129 // Dynamic changes of CSS properties like 'clip-path' may require us to reco mpute the associated resources for a renderer. 129 // Dynamic changes of CSS properties like 'clip-path' may require us to reco mpute the associated resources for a renderer.
130 // FIXME: Avoid passing in a useless StyleDifference, but instead compare ol dStyle/newStyle to see which resources changed 130 // FIXME: Avoid passing in a useless StyleDifference, but instead compare ol dStyle/newStyle to see which resources changed
131 // to be able to selectively rebuild individual resources, instead of all of them. 131 // to be able to selectively rebuild individual resources, instead of all of them.
132 if (rendererCanHaveResources(renderer)) { 132 if (rendererCanHaveResources(renderer)) {
133 SVGResourcesCache* cache = resourcesCacheFromRenderObject(renderer); 133 SVGResourcesCache* cache = resourcesCacheFromRenderObject(renderer);
134 cache->removeResourcesFromRenderObject(renderer); 134 cache->removeResourcesFromRenderObject(renderer);
135 cache->addResourcesFromRenderObject(renderer, newStyle); 135 cache->addResourcesFromRenderObject(renderer, newStyle);
136 } 136 }
137 137
138 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer, fals e); 138 RenderSVGResourceContainer::markForLayoutAndParentResourceInvalidation(rende rer, false);
139 } 139 }
140 140
141 void SVGResourcesCache::clientWasAddedToTree(RenderObject* renderer, const Rende rStyle* newStyle) 141 void SVGResourcesCache::clientWasAddedToTree(RenderObject* renderer, const Rende rStyle* newStyle)
142 { 142 {
143 if (!renderer->node()) 143 if (!renderer->node())
144 return; 144 return;
145 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer, fals e); 145 RenderSVGResourceContainer::markForLayoutAndParentResourceInvalidation(rende rer, false);
146 146
147 if (!rendererCanHaveResources(renderer)) 147 if (!rendererCanHaveResources(renderer))
148 return; 148 return;
149 SVGResourcesCache* cache = resourcesCacheFromRenderObject(renderer); 149 SVGResourcesCache* cache = resourcesCacheFromRenderObject(renderer);
150 cache->addResourcesFromRenderObject(renderer, newStyle); 150 cache->addResourcesFromRenderObject(renderer, newStyle);
151 } 151 }
152 152
153 void SVGResourcesCache::clientWillBeRemovedFromTree(RenderObject* renderer) 153 void SVGResourcesCache::clientWillBeRemovedFromTree(RenderObject* renderer)
154 { 154 {
155 if (!renderer->node()) 155 if (!renderer->node())
156 return; 156 return;
157 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer, fals e); 157 RenderSVGResourceContainer::markForLayoutAndParentResourceInvalidation(rende rer, false);
158 158
159 if (!rendererCanHaveResources(renderer)) 159 if (!rendererCanHaveResources(renderer))
160 return; 160 return;
161 SVGResourcesCache* cache = resourcesCacheFromRenderObject(renderer); 161 SVGResourcesCache* cache = resourcesCacheFromRenderObject(renderer);
162 cache->removeResourcesFromRenderObject(renderer); 162 cache->removeResourcesFromRenderObject(renderer);
163 } 163 }
164 164
165 void SVGResourcesCache::clientDestroyed(RenderObject* renderer) 165 void SVGResourcesCache::clientDestroyed(RenderObject* renderer)
166 { 166 {
167 ASSERT(renderer); 167 ASSERT(renderer);
(...skipping 20 matching lines...) Expand all
188 // Mark users of destroyed resources as pending resolution based on the id of the old resource. 188 // Mark users of destroyed resources as pending resolution based on the id of the old resource.
189 Element* resourceElement = resource->element(); 189 Element* resourceElement = resource->element();
190 Element* clientElement = toElement(objectResources.key->node()); 190 Element* clientElement = toElement(objectResources.key->node());
191 SVGDocumentExtensions& extensions = clientElement->document().accessSVGE xtensions(); 191 SVGDocumentExtensions& extensions = clientElement->document().accessSVGE xtensions();
192 192
193 extensions.addPendingResource(resourceElement->fastGetAttribute(HTMLName s::idAttr), clientElement); 193 extensions.addPendingResource(resourceElement->fastGetAttribute(HTMLName s::idAttr), clientElement);
194 } 194 }
195 } 195 }
196 196
197 } 197 }
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceContainer.cpp ('k') | Source/core/svg/SVGAnimateMotionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698