Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Unified Diff: Source/platform/graphics/GraphicsContext.h

Issue 669123002: Fixed Shadow blur for transparent objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added missing virtual layout test to TestExpectations Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/GraphicsContext.h
diff --git a/Source/platform/graphics/GraphicsContext.h b/Source/platform/graphics/GraphicsContext.h
index f3e837ba9e9bab5ed9918c0b6b6f68a24ee9733a..9600287fee967d26e99c1a4e5a2faee373e70fbc 100644
--- a/Source/platform/graphics/GraphicsContext.h
+++ b/Source/platform/graphics/GraphicsContext.h
@@ -342,7 +342,7 @@ public:
void setShadow(const FloatSize& offset, float blur, const Color&,
DrawLooperBuilder::ShadowTransformMode = DrawLooperBuilder::ShadowRespectsTransforms,
DrawLooperBuilder::ShadowAlphaMode = DrawLooperBuilder::ShadowRespectsAlpha, ShadowMode = DrawShadowAndForeground);
- void clearShadow() { clearDrawLooper(); }
+ void clearShadow() { clearDrawLooper(); clearDropShadowImageFilter(); }
// It is assumed that this draw looper is used only for shadows
// (i.e. a draw looper is set if and only if there is a shadow).
@@ -401,6 +401,7 @@ public:
const SkRect& destRect,
CompositeOperator,
WebBlendMode,
+ bool isBitmapWithAlpha,
bool isLazyDecoded = false,
bool isDataComplete = true) const;
@@ -450,6 +451,10 @@ private:
void concat(const SkMatrix&);
void drawRRect(const SkRRect&, const SkPaint&);
+ void setDropShadowImageFilter(PassRefPtr<SkImageFilter>);
+ void clearDropShadowImageFilter();
+ SkImageFilter* dropShadowImageFilter() const { return immutableState()->dropShadowImageFilter(); }
+
// Apply deferred paint state saves
void realizePaintSave()
{

Powered by Google App Engine
This is Rietveld 408576698