Source/core/paint/BoxPainter.cpp - Issue 669123002: Fixed Shadow blur for transparent objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/BoxPainter.cpp

Issue 669123002: Fixed Shadow blur for transparent objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added missing virtual layout test to TestExpectations Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-shadow-source-in-expected.html ('k') | Source/platform/graphics/GraphicsContext.h » ('j') | Source/platform/graphics/GraphicsContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/BoxPainter.cpp

diff --git a/Source/core/paint/BoxPainter.cpp b/Source/core/paint/BoxPainter.cpp

index 5a190b02e2036159d99dd092e1a777125cc52221..f4698d911ab1981c97a3d44c7a6e6003578ea4d6 100644

--- a/Source/core/paint/BoxPainter.cpp

+++ b/Source/core/paint/BoxPainter.cpp

@@ -1923,10 +1923,7 @@ void BoxPainter::paintBoxShadow(const PaintInfo& info, const LayoutRect& paintRe

}

// Draw only the shadow.

- OwnPtr<DrawLooperBuilder> drawLooperBuilder = DrawLooperBuilder::create();

- drawLooperBuilder->addShadow(shadowOffset, shadowBlur, shadowColor,

- DrawLooperBuilder::ShadowRespectsTransforms, DrawLooperBuilder::ShadowIgnoresAlpha);

- context->setDrawLooper(drawLooperBuilder.release());

+ context->setShadow(shadowOffset, shadowBlur, shadowColor, DrawLooperBuilder::ShadowRespectsTransforms, DrawLooperBuilder::ShadowIgnoresAlpha, DrawShadowOnly);

if (hasBorderRadius) {

RoundedRect influenceRect(pixelSnappedIntRect(LayoutRect(shadowRect)), border.radii());