Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 668963002: Delay calling FrameOwner::setWidget when doing a remote->local frame transition (Closed)

Created:
6 years, 2 months ago by Nate Chapin
Modified:
6 years, 2 months ago
Reviewers:
dcheng
CC:
dcheng, blink-reviews, mkwst+moarreviews_chromium.org, site-isolation-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Delay calling FrameOwner::setWidget when doing a remote->local frame transition If we call setWidget for a newly created LocalFrame that's not fully attached to the frame tree, it will be in an inconsistent state and cause crashes during painting. Instead, update the widget at swap-time, when the frame actually becomes fully attached. BUG=422583 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184313

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M Source/core/frame/LocalFrame.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/web/WebFrame.cpp View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nate Chapin
Another quirk to get remote->local frame swap working :-/
6 years, 2 months ago (2014-10-21 20:26:50 UTC) #2
dcheng
LGTM. ... this makes me so sad.
6 years, 2 months ago (2014-10-23 20:42:14 UTC) #3
Nate Chapin
On 2014/10/23 20:42:14, dcheng wrote: > LGTM. > > ... this makes me so sad. ...
6 years, 2 months ago (2014-10-23 20:42:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668963002/20001
6 years, 2 months ago (2014-10-23 20:43:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33358)
6 years, 2 months ago (2014-10-23 22:51:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668963002/20001
6 years, 2 months ago (2014-10-23 22:57:17 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:40:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184313

Powered by Google App Engine
This is Rietveld 408576698