Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 668963002: Delay calling FrameOwner::setWidget when doing a remote->local frame transition (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/WebFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/LocalFrame.cpp
diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp
index 43bcd9c4211cf7ee98b2ac6db11f43611f02b05e..0e2ae7bfc6bbb4bb13862f3f86c482b10bce9676 100644
--- a/Source/core/frame/LocalFrame.cpp
+++ b/Source/core/frame/LocalFrame.cpp
@@ -483,7 +483,11 @@ void LocalFrame::createView(const IntSize& viewportSize, const Color& background
if (ownerRenderer()) {
HTMLFrameOwnerElement* owner = deprecatedLocalOwner();
ASSERT(owner);
- owner->setWidget(frameView);
+ // FIXME: OOPI might lead to us temporarily lying to a frame and telling it
+ // that it's owned by a FrameOwner that knows nothing about it. If we're
+ // lying to this frame, don't let it clobber the existing widget.
+ if (owner->contentFrame() == this)
+ owner->setWidget(frameView);
}
if (HTMLFrameOwnerElement* owner = deprecatedLocalOwner())
« no previous file with comments | « no previous file | Source/web/WebFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698