Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: Source/core/frame/LocalFrame.cpp

Issue 668963002: Delay calling FrameOwner::setWidget when doing a remote->local frame transition (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/web/WebFrame.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 476
477 frameView->updateBackgroundRecursively(backgroundColor, transparent); 477 frameView->updateBackgroundRecursively(backgroundColor, transparent);
478 478
479 if (isLocalRoot) 479 if (isLocalRoot)
480 frameView->setParentVisible(true); 480 frameView->setParentVisible(true);
481 481
482 // FIXME: Not clear what the right thing for OOPI is here. 482 // FIXME: Not clear what the right thing for OOPI is here.
483 if (ownerRenderer()) { 483 if (ownerRenderer()) {
484 HTMLFrameOwnerElement* owner = deprecatedLocalOwner(); 484 HTMLFrameOwnerElement* owner = deprecatedLocalOwner();
485 ASSERT(owner); 485 ASSERT(owner);
486 owner->setWidget(frameView); 486 // FIXME: OOPI might lead to us temporarily lying to a frame and telling it
487 // that it's owned by a FrameOwner that knows nothing about it. If we're
488 // lying to this frame, don't let it clobber the existing widget.
489 if (owner->contentFrame() == this)
490 owner->setWidget(frameView);
487 } 491 }
488 492
489 if (HTMLFrameOwnerElement* owner = deprecatedLocalOwner()) 493 if (HTMLFrameOwnerElement* owner = deprecatedLocalOwner())
490 view()->setCanHaveScrollbars(owner->scrollingMode() != ScrollbarAlwaysOf f); 494 view()->setCanHaveScrollbars(owner->scrollingMode() != ScrollbarAlwaysOf f);
491 } 495 }
492 496
493 497
494 void LocalFrame::countObjectsNeedingLayout(unsigned& needsLayoutObjects, unsigne d& totalObjects, bool& isPartial) 498 void LocalFrame::countObjectsNeedingLayout(unsigned& needsLayoutObjects, unsigne d& totalObjects, bool& isPartial)
495 { 499 {
496 RenderObject* root = view()->layoutRoot(); 500 RenderObject* root = view()->layoutRoot();
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
773 } 777 }
774 778
775 void LocalFrame::unregisterPluginElement(HTMLPlugInElement* plugin) 779 void LocalFrame::unregisterPluginElement(HTMLPlugInElement* plugin)
776 { 780 {
777 ASSERT(m_pluginElements.contains(plugin)); 781 ASSERT(m_pluginElements.contains(plugin));
778 m_pluginElements.remove(plugin); 782 m_pluginElements.remove(plugin);
779 } 783 }
780 #endif 784 #endif
781 785
782 } // namespace blink 786 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/web/WebFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698