Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings

This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings
(Ref: binding-methods changed:
static PassOwnPtr<ArrayBufferContentsArray> transferArrayBuffers(ArrayBufferArray&, ExceptionState&, v8::Isolate*)
void addHiddenValueToArray(v8::Handle<v8::Object>, v8::Local<v8::Value>, int cacheIndex, v8::Isolate*)
void removeHiddenValueFromArray(v8::Handle<v8::Object>, v8::Local<v8::Value>, int cacheIndex, v8::Isolate*)
void moveEventListenerToNewWrapper(v8::Handle<v8::Object>, EventListener* oldValue, v8::Local<v8::Value> newValue, int cacheIndex, v8::Isolate*)
PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(ExecutionContext*, v8::Handle<v8::Function>, v8::Isolate*))

BUG=424446
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184174

[RAGHURAM, 2014-10-20 12:32:57]

r.nagaraj@samsung.com changed reviewers:
+ haraken@chromium.org

[RAGHURAM, 2014-10-20 12:32:58]

Please Review.

Thanks & Regards

[haraken, 2014-10-20 13:54:28]

LGTM

[RAGHURAM, 2014-10-21 06:08:08]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-10-21 06:09:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668673002/1

[commit-bot: I haz the power, 2014-10-21 06:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 06:16:17]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[RAGHURAM, 2014-10-21 06:17:59]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-10-21 06:18:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668673002/1

[commit-bot: I haz the power, 2014-10-21 06:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 06:25:38]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[RAGHURAM, 2014-10-21 09:23:56]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-10-21 09:24:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668673002/1

[commit-bot: I haz the power, 2014-10-21 09:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 09:40:05]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27893)

[RAGHURAM, 2014-10-21 09:58:20]

On 2014/10/20 13:54:28, haraken wrote:
> LGTM

@haraken:

Hi

I am facing some commit errors as you might have noticed. Could not understand
much from the logs.
Note: While I was building on my local machine, the src/out folder was throwing
some errors as it had references to couple of the binding methods
(addHiddenValueToArray() & removeHiddenValueFromArray()) whose signatures I have
changed. Since the file was a auto-generated I thought the issue would be
resolved. I dont know if its of any relevance.

Please guide me. Any help would be appreciated.

Thanks & Regards

[haraken, 2014-10-21 10:40:06]

On 2014/10/21 09:58:20, RAGHURAM wrote:
> On 2014/10/20 13:54:28, haraken wrote:
> > LGTM
> 
> @haraken:
> 
> Hi
> 
> I am facing some commit errors as you might have noticed. Could not understand
> much from the logs.
> Note: While I was building on my local machine, the src/out folder was
throwing
> some errors as it had references to couple of the binding methods
> (addHiddenValueToArray() & removeHiddenValueFromArray()) whose signatures I
have
> changed. Since the file was a auto-generated I thought the issue would be
> resolved. I dont know if its of any relevance.
> 
> Please guide me. Any help would be appreciated.
> 
> Thanks & Regards

Those files are generated by scripts in bindings/scripts/ and templates in
bindings/templates/, so you need to edit those files as well.

In this case, you need to edit bindings/templates/methods.cpp.

[RAGHURAM, 2014-10-22 06:37:28]

On 2014/10/21 10:40:06, haraken wrote:
> On 2014/10/21 09:58:20, RAGHURAM wrote:
> > On 2014/10/20 13:54:28, haraken wrote:
> > > LGTM
> > 
> > @haraken:
> > 
> > Hi
> > 
> > I am facing some commit errors as you might have noticed. Could not
understand
> > much from the logs.
> > Note: While I was building on my local machine, the src/out folder was
> throwing
> > some errors as it had references to couple of the binding methods
> > (addHiddenValueToArray() & removeHiddenValueFromArray()) whose signatures I
> have
> > changed. Since the file was a auto-generated I thought the issue would be
> > resolved. I dont know if its of any relevance.
> > 
> > Please guide me. Any help would be appreciated.
> > 
> > Thanks & Regards
> 
> Those files are generated by scripts in bindings/scripts/ and templates in
> bindings/templates/, so you need to edit those files as well.
> 
> In this case, you need to edit bindings/templates/methods.cpp.

Hi

I think I have made the required changes. PTAL.

Thanks & Regards

[haraken, 2014-10-22 07:00:17]

LGTM

[RAGHURAM, 2014-10-22 07:05:45]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-10-22 07:06:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668673002/20001

[commit-bot: I haz the power, 2014-10-22 07:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 07:20:30]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/3...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[RAGHURAM, 2014-10-22 10:32:57]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-10-22 10:34:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668673002/20001

[commit-bot: I haz the power, 2014-10-22 12:18:45]

Committed patchset #2 (id:20001) as 184174