Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp - Issue 668673002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

Issue 668673002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

diff --git a/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp b/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

index 3665327db76196778dbecf2b51f8e8bbad6f32ce..ecf75ea2f49771cd3cb358739338fbe18ba25272 100644

--- a/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

+++ b/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

@@ -77,7 +77,7 @@ v8::Local<v8::Value> V8WorkerGlobalScopeEventListener::callListenerFunction(v8::

if (handlerFunction.IsEmpty() || receiver.IsEmpty())

return v8::Local<v8::Value>();

- TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "FunctionCall", "data", devToolsTraceEventData(scriptState()->executionContext(), handlerFunction, isolate()));

+ TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "FunctionCall", "data", devToolsTraceEventData(isolate(), scriptState()->executionContext(), handlerFunction));

TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline.stack"), "CallStack", "stack", InspectorCallStackEvent::currentCallStack());

// FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeline migrates to tracing.

InspectorInstrumentationCookie cookie;

« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »