Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 668673002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8Binding.cpp
diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp
index ba735963c8a6abfcad78df801028552df8c60c61..4fe108f2d1554a3c87e451323b8f8c55370f62b8 100644
--- a/Source/bindings/core/v8/V8Binding.cpp
+++ b/Source/bindings/core/v8/V8Binding.cpp
@@ -826,7 +826,7 @@ v8::Handle<v8::Function> getBoundFunction(v8::Handle<v8::Function> function)
return boundFunction->IsFunction() ? v8::Handle<v8::Function>::Cast(boundFunction) : function;
}
-void addHiddenValueToArray(v8::Handle<v8::Object> object, v8::Local<v8::Value> value, int arrayIndex, v8::Isolate* isolate)
+void addHiddenValueToArray(v8::Isolate* isolate, v8::Handle<v8::Object> object, v8::Local<v8::Value> value, int arrayIndex)
{
v8::Local<v8::Value> arrayValue = object->GetInternalField(arrayIndex);
if (arrayValue->IsNull() || arrayValue->IsUndefined()) {
@@ -838,7 +838,7 @@ void addHiddenValueToArray(v8::Handle<v8::Object> object, v8::Local<v8::Value> v
array->Set(v8::Integer::New(isolate, array->Length()), value);
}
-void removeHiddenValueFromArray(v8::Handle<v8::Object> object, v8::Local<v8::Value> value, int arrayIndex, v8::Isolate* isolate)
+void removeHiddenValueFromArray(v8::Isolate* isolate, v8::Handle<v8::Object> object, v8::Local<v8::Value> value, int arrayIndex)
{
v8::Local<v8::Value> arrayValue = object->GetInternalField(arrayIndex);
if (!arrayValue->IsArray())
@@ -853,19 +853,19 @@ void removeHiddenValueFromArray(v8::Handle<v8::Object> object, v8::Local<v8::Val
}
}
-void moveEventListenerToNewWrapper(v8::Handle<v8::Object> object, EventListener* oldValue, v8::Local<v8::Value> newValue, int arrayIndex, v8::Isolate* isolate)
+void moveEventListenerToNewWrapper(v8::Isolate* isolate, v8::Handle<v8::Object> object, EventListener* oldValue, v8::Local<v8::Value> newValue, int arrayIndex)
{
if (oldValue) {
V8AbstractEventListener* oldListener = V8AbstractEventListener::cast(oldValue);
if (oldListener) {
v8::Local<v8::Object> oldListenerObject = oldListener->getExistingListenerObject();
if (!oldListenerObject.IsEmpty())
- removeHiddenValueFromArray(object, oldListenerObject, arrayIndex, isolate);
+ removeHiddenValueFromArray(isolate, object, oldListenerObject, arrayIndex);
}
}
// Non-callable input is treated as null and ignored
if (newValue->IsFunction())
- addHiddenValueToArray(object, newValue, arrayIndex, isolate);
+ addHiddenValueToArray(isolate, object, newValue, arrayIndex);
}
v8::Isolate* toIsolate(ExecutionContext* context)
@@ -975,7 +975,7 @@ void GetDevToolsFunctionInfo(v8::Handle<v8::Function> function, v8::Isolate* iso
}
}
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(ExecutionContext* context, v8::Handle<v8::Function> function, v8::Isolate* isolate)
+PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(v8::Isolate* isolate, ExecutionContext* context, v8::Handle<v8::Function> function)
{
int scriptId = 0;
String resourceName;
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698