Issue 668663003: Avoid multiple failures to inline functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668663003: Avoid multiple failures to inline functions (Closed)

Created:
6 years, 2 months ago by wingo

Modified:
6 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Avoid multiple failures to inline functions R=mstarzinger@chromium.org BUG=

Patch Set 1 #

Total comments: 4

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+2 lines, -0 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wingo

This looks right to me, or at least I can't convince myself it's wrong. WDYT?

6 years, 2 months ago (2014-10-20 16:49:02 UTC) #1

Michael Starzinger

https://codereview.chromium.org/668663003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/668663003/diff/1/src/hydrogen.cc#newcode7853 src/hydrogen.cc:7853: target_shared->set_ast_node_count(nodes_added); This should now be superseded by https://codereview.chromium.org/675493002/, correct? ...

6 years, 1 month ago (2014-10-27 13:27:48 UTC) #2

wingo

6 years, 1 month ago (2014-10-27 15:06:51 UTC) #3

Thanks for review; will move to https://codereview.chromium.org/668143003 for
further discussion.

https://codereview.chromium.org/668663003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/668663003/diff/1/src/hydrogen.cc#newcode7853
src/hydrogen.cc:7853: target_shared->set_ast_node_count(nodes_added);
On 2014/10/27 13:27:48, Michael Starzinger wrote:
> This should now be superseded by https://codereview.chromium.org/675493002/,
> correct?

Yes indeed.

https://codereview.chromium.org/668663003/diff/1/src/hydrogen.cc#newcode7858
src/hydrogen.cc:7858:
target_shared->set_dont_optimize_reason(function->dont_optimize_reason());
On 2014/10/27 13:27:48, Michael Starzinger wrote:
> This scares me, could we instead make it go through
> SharedFunctionInfo::DisableOptimization?

So this part of the CL is superseded by
https://codereview.chromium.org/668143003, but I guess the comment applies there
too:

  https://codereview.chromium.org/668143003/diff/60001/src/compiler.cc

I'll add you to Cc there and fix that patch.

Expand Messages | Collapse Messages