Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: src/hydrogen.cc

Issue 668663003: Avoid multiple failures to inline functions (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 3f9d32de1c5ee3153026bb218fdf48f1e40e5a8a..f34814366f65162a7db57c88c3b1bfd21b0d4234 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -7850,10 +7850,12 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
// earlier the information might not have been complete due to lazy parsing.
nodes_added = function->ast_node_count();
if (nodes_added > Min(FLAG_max_inlined_nodes, kUnlimitedMaxInlinedNodes)) {
+ target_shared->set_ast_node_count(nodes_added);
Michael Starzinger 2014/10/27 13:27:48 This should now be superseded by https://coderevie
wingo 2014/10/27 15:06:51 Yes indeed.
TraceInline(target, caller, "target AST is too large [late]");
return false;
}
if (function->dont_optimize()) {
+ target_shared->set_dont_optimize_reason(function->dont_optimize_reason());
Michael Starzinger 2014/10/27 13:27:48 This scares me, could we instead make it go throug
wingo 2014/10/27 15:06:51 So this part of the CL is superseded by https://co
TraceInline(target, caller, "target contains unsupported syntax [late]");
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698