Avoid multiple failures to inline functions

src/hydrogen.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/hydrogen.h"
 
 #include <sstream>
 
 #include "src/v8.h"
 
@@ skipping 7832 matching lines @@
   if (target_info.scope()->num_heap_slots() > 0) {
     TraceInline(target, caller, "target has context-allocated variables");
     return false;
   }
   FunctionLiteral* function = target_info.function();
 
   // The following conditions must be checked again after re-parsing, because
   // earlier the information might not have been complete due to lazy parsing.
   nodes_added = function->ast_node_count();
   if (nodes_added > Min(FLAG_max_inlined_nodes, kUnlimitedMaxInlinedNodes)) {
+    target_shared->set_ast_node_count(nodes_added);

[Michael Starzinger, 2014/10/27 13:27:48]

This should now be superseded by https://codereview.chromium.org/675493002/,
correct?

[wingo, 2014/10/27 15:06:51]

Yes indeed.

     TraceInline(target, caller, "target AST is too large [late]");
     return false;
   }
   if (function->dont_optimize()) {
+    target_shared->set_dont_optimize_reason(function->dont_optimize_reason());

[Michael Starzinger, 2014/10/27 13:27:48]

This scares me, could we instead make it go through
SharedFunctionInfo::DisableOptimization?

[wingo, 2014/10/27 15:06:51]

So this part of the CL is superseded by
https://codereview.chromium.org/668143003, but I guess the comment applies there
too:

  https://codereview.chromium.org/668143003/diff/60001/src/compiler.cc

I'll add you to Cc there and fix that patch.

     TraceInline(target, caller, "target contains unsupported syntax [late]");
     return false;
   }
 
   // If the function uses the arguments object check that inlining of functions
   // with arguments object is enabled and the arguments-variable is
   // stack allocated.
   if (function->scope()->arguments() != NULL) {
     if (!FLAG_inline_arguments) {
       TraceInline(target, caller, "target uses arguments object");
@@ skipping 4786 matching lines @@
   if (ShouldProduceTraceOutput()) {
     isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
   }
 
 #ifdef DEBUG
   graph_->Verify(false);  // No full verify.
 #endif
 }
 
 } }  // namespace v8::internal