Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 6685119: [Arguments] Remove the arguments shadow symbol. (Closed)

Created:
9 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

[Arguments] Remove the arguments shadow symbol. The only essential use remaining was to detect an allocated arguments object to avoid OSR. The shared function info now has a flag indicating that there might be an allocated arguments object so we can avoid OSR for those functions. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7287

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -117 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.cc View 7 chunks +22 lines, -36 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-profiler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 1 comment Download
M src/objects.h View 4 chunks +9 lines, -11 lines 0 comments Download
M src/objects-inl.h View 5 chunks +18 lines, -26 lines 0 comments Download
M src/runtime.cc View 3 chunks +8 lines, -33 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopeinfo.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
http://codereview.chromium.org/6685119/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/6685119/diff/1/src/ia32/full-codegen-ia32.cc#newcode1138 src/ia32/full-codegen-ia32.cc:1138: ASSERT((var->is_global() && !var->is_this()) == (slot == NULL)); This was ...
9 years, 9 months ago (2011-03-21 13:46:27 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-21 14:09:31 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698