src/runtime-profiler.cc - Issue 6685119: [Arguments] Remove the arguments shadow symbol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime-profiler.cc

Issue 6685119: [Arguments] Remove the arguments shadow symbol. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/arguments

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime-profiler.cc

diff --git a/src/runtime-profiler.cc b/src/runtime-profiler.cc

index df6471e9d5b9a258e7dfd8ddb098f05459f95927..62a2d46a54094bca7352e482f2bd1606a40101be 100644

--- a/src/runtime-profiler.cc

+++ b/src/runtime-profiler.cc

@@ -169,7 +169,7 @@ static void AttemptOnStackReplacement(JSFunction* function) {

// We are not prepared to do OSR for a function that already has an

// allocated arguments object. The optimized code would bypass it for

// arguments accesses, which is unsound. Don't try OSR.

- if (shared->scope_info()->HasArgumentsShadow()) return;

+ if (shared->uses_arguments()) return;

// We're using on-stack replacement: patch the unoptimized code so that

// any back edge in any unoptimized frame will trigger on-stack