Issue 668223002: SkResourceCache::Key namespace support.

Issue 668223002: SkResourceCache::Key namespace support. (Closed)

Created:
6 years, 2 months ago by f(malita)

Modified:
6 years, 2 months ago

Reviewers:
mtklein, bsalomon, robertphillips, reed1

CC:
reviews_skia.org, qiankun

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

SkResourceCache::Key namespace support. Add a unique-per-subclass namespace tag to make Keys from different domains comparable. Also drop the SkPictureShader cache and convert to using the global resource cache instead. R=reed@google.com,mtklein@google.com,robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/171e5b73a862418f4acd61faf8cecfbc8f58694c

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -69 lines)			Patch
M	bench/ImageCacheBench.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/core/SkBitmapCache.cpp	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	src/core/SkPictureShader.cpp	View	1	5 chunks	+12 lines, -55 lines	0 comments	Download
M	src/core/SkResourceCache.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/core/SkResourceCache.cpp	View		2 chunks	+17 lines, -5 lines	0 comments	Download
M	tests/ImageCacheTest.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 8 (2 generated)

f(malita)

On 2014/10/22 17:53:20, mtklein wrote: > Using the address of a static is really clever. ...

6 years, 2 months ago (2014-10-22 17:55:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668223002/20001

6 years, 2 months ago (2014-10-22 18:19:09 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 18:20:44 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 171e5b73a862418f4acd61faf8cecfbc8f58694c