Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 668113003: SVGElement::parseAttribute resolves property via property map (Step 2.6) (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
haraken, pdr., fs
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

SVGElement::parseAttribute resolves property via property map (Step 2.6) SVGAnimatedOrder is introduced to handle parse errors for SVGFEConvolveMatrixElement's orderAttr in setBaseValueToString. This is to replace the existing |SVGElement::parseAttribute| implementation, but as there are many callers, we would like to proceed this incrementally. a) Introduce |SVGElement::parseAttributeNew| *LANDED* b) Convert all overrides |SVGElement::parseAttribute| to a |parseAttributeNew| call. <-- This patch c) Replace existing |parseAttribute| with |parseAttributeNew|, and remove all overrides simply calling |parseAttributeNew| This patch is (b). BUG=397902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -201 lines) Patch
M Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +1 line, -25 lines 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.cpp View 3 chunks +30 lines, -37 lines 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +1 line, -19 lines 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +1 line, -21 lines 0 comments Download
M Source/core/svg/SVGFETileElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFETileElement.cpp View 1 chunk +3 lines, -29 lines 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +1 line, -21 lines 0 comments Download
M Source/core/svg/SVGStopElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGStopElement.cpp View 1 chunk +6 lines, -32 lines 0 comments Download
M Source/core/svg/SVGStyleElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGStyleElement.cpp View 1 chunk +2 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kouhei (in TOK)
PTAL when you have time. Hopefully 3 elements left after this CL.
6 years, 2 months ago (2014-10-22 09:15:40 UTC) #2
fs
lgtm
6 years, 2 months ago (2014-10-22 10:30:27 UTC) #3
haraken
LGTM
6 years, 2 months ago (2014-10-22 10:31:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668113003/1
6 years, 2 months ago (2014-10-22 11:02:23 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 11:14:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184167

Powered by Google App Engine
This is Rietveld 408576698