Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Side by Side Diff: Source/core/svg/SVGFETileElement.cpp

Issue 668113003: SVGElement::parseAttribute resolves property via property map (Step 2.6) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGFETileElement.h ('k') | Source/core/svg/SVGMaskElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 19 matching lines...) Expand all
30 30
31 inline SVGFETileElement::SVGFETileElement(Document& document) 31 inline SVGFETileElement::SVGFETileElement(Document& document)
32 : SVGFilterPrimitiveStandardAttributes(SVGNames::feTileTag, document) 32 : SVGFilterPrimitiveStandardAttributes(SVGNames::feTileTag, document)
33 , m_in1(SVGAnimatedString::create(this, SVGNames::inAttr, SVGString::create( ))) 33 , m_in1(SVGAnimatedString::create(this, SVGNames::inAttr, SVGString::create( )))
34 { 34 {
35 addToPropertyMap(m_in1); 35 addToPropertyMap(m_in1);
36 } 36 }
37 37
38 DEFINE_NODE_FACTORY(SVGFETileElement) 38 DEFINE_NODE_FACTORY(SVGFETileElement)
39 39
40 bool SVGFETileElement::isSupportedAttribute(const QualifiedName& attrName)
41 {
42 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
43 if (supportedAttributes.isEmpty())
44 supportedAttributes.add(SVGNames::inAttr);
45 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
46 }
47
48 void SVGFETileElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value) 40 void SVGFETileElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
49 { 41 {
50 if (!isSupportedAttribute(name)) { 42 parseAttributeNew(name, value);
51 SVGFilterPrimitiveStandardAttributes::parseAttribute(name, value);
52 return;
53 }
54
55 SVGParsingError parseError = NoError;
56
57 if (name == SVGNames::inAttr)
58 m_in1->setBaseValueAsString(value, parseError);
59 else
60 ASSERT_NOT_REACHED();
61
62 reportAttributeParsingError(parseError, name, value);
63 } 43 }
64 44
65 void SVGFETileElement::svgAttributeChanged(const QualifiedName& attrName) 45 void SVGFETileElement::svgAttributeChanged(const QualifiedName& attrName)
66 { 46 {
67 if (!isSupportedAttribute(attrName)) {
68 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
69 return;
70 }
71
72 SVGElement::InvalidationGuard invalidationGuard(this);
73
74 if (attrName == SVGNames::inAttr) { 47 if (attrName == SVGNames::inAttr) {
48 SVGElement::InvalidationGuard invalidationGuard(this);
75 invalidate(); 49 invalidate();
76 return; 50 return;
77 } 51 }
78 52
79 ASSERT_NOT_REACHED(); 53 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
80 } 54 }
81 55
82 PassRefPtr<FilterEffect> SVGFETileElement::build(SVGFilterBuilder* filterBuilder , Filter* filter) 56 PassRefPtr<FilterEffect> SVGFETileElement::build(SVGFilterBuilder* filterBuilder , Filter* filter)
83 { 57 {
84 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->curr entValue()->value())); 58 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->curr entValue()->value()));
85 59
86 if (!input1) 60 if (!input1)
87 return nullptr; 61 return nullptr;
88 62
89 RefPtr<FilterEffect> effect = FETile::create(filter); 63 RefPtr<FilterEffect> effect = FETile::create(filter);
90 effect->inputEffects().append(input1); 64 effect->inputEffects().append(input1);
91 return effect.release(); 65 return effect.release();
92 } 66 }
93 67
94 } 68 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGFETileElement.h ('k') | Source/core/svg/SVGMaskElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698