Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Unified Diff: Source/core/svg/SVGMaskElement.cpp

Issue 668113003: SVGElement::parseAttribute resolves property via property map (Step 2.6) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFETileElement.cpp ('k') | Source/core/svg/SVGStopElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGMaskElement.cpp
diff --git a/Source/core/svg/SVGMaskElement.cpp b/Source/core/svg/SVGMaskElement.cpp
index e3d090ff02124a27100093cc1685b5398dde313e..b3391238dd6417246647b14e441c60dd7c567584 100644
--- a/Source/core/svg/SVGMaskElement.cpp
+++ b/Source/core/svg/SVGMaskElement.cpp
@@ -74,27 +74,7 @@ bool SVGMaskElement::isSupportedAttribute(const QualifiedName& attrName)
void SVGMaskElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- SVGParsingError parseError = NoError;
-
- if (!isSupportedAttribute(name))
- SVGElement::parseAttribute(name, value);
- else if (name == SVGNames::maskUnitsAttr)
- m_maskUnits->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::maskContentUnitsAttr)
- m_maskContentUnits->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::xAttr)
- m_x->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::yAttr)
- m_y->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::widthAttr)
- m_width->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::heightAttr)
- m_height->setBaseValueAsString(value, parseError);
- else if (SVGTests::parseAttribute(name, value)) {
- } else
- ASSERT_NOT_REACHED();
-
- reportAttributeParsingError(parseError, name, value);
+ parseAttributeNew(name, value);
}
void SVGMaskElement::svgAttributeChanged(const QualifiedName& attrName)
« no previous file with comments | « Source/core/svg/SVGFETileElement.cpp ('k') | Source/core/svg/SVGStopElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698