content/browser/web_contents/web_contents_user_data_unittest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_user_data_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/browser/web_contents/web_contents_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_user_data_unittest.cc

diff --git a/content/browser/web_contents/web_contents_user_data_unittest.cc b/content/browser/web_contents/web_contents_user_data_unittest.cc

index acec01ded69dc26fbe2c76119abae1b7c971e17d..eeb2acb3de23920df007cbc4328e44e8c07bb6fb 100644

--- a/content/browser/web_contents/web_contents_user_data_unittest.cc

+++ b/content/browser/web_contents/web_contents_user_data_unittest.cc

@@ -15,7 +15,8 @@ namespace content {

class WebContentsAttachedClass1

: public WebContentsUserData<WebContentsAttachedClass1> {

public:

- virtual ~WebContentsAttachedClass1() {}

+ ~WebContentsAttachedClass1() override {}

private:

explicit WebContentsAttachedClass1(WebContents* contents) {}

friend class WebContentsUserData<WebContentsAttachedClass1>;

@@ -24,7 +25,8 @@ class WebContentsAttachedClass1

class WebContentsAttachedClass2

: public WebContentsUserData<WebContentsAttachedClass2> {

public:

- virtual ~WebContentsAttachedClass2() {}

+ ~WebContentsAttachedClass2() override {}

private:

explicit WebContentsAttachedClass2(WebContents* contents) {}

friend class WebContentsUserData<WebContentsAttachedClass2>;