Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 645c8254a8c4d5bb0aba648419acc02afa7bdbca..1a907b1a8bc6c3085c56c6d74ce34ab7e4cea873 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -44,25 +44,25 @@ const char kTestWebUIUrl[] = "chrome://blah";
class WebContentsImplTestWebUIControllerFactory
: public WebUIControllerFactory {
public:
- virtual WebUIController* CreateWebUIControllerForURL(
- WebUI* web_ui, const GURL& url) const override {
+ WebUIController* CreateWebUIControllerForURL(WebUI* web_ui,
+ const GURL& url) const override {
if (!UseWebUI(url))
return NULL;
return new WebUIController(web_ui);
}
- virtual WebUI::TypeID GetWebUIType(BrowserContext* browser_context,
- const GURL& url) const override {
+ WebUI::TypeID GetWebUIType(BrowserContext* browser_context,
+ const GURL& url) const override {
return WebUI::kNoWebUI;
}
- virtual bool UseWebUIForURL(BrowserContext* browser_context,
- const GURL& url) const override {
+ bool UseWebUIForURL(BrowserContext* browser_context,
+ const GURL& url) const override {
return UseWebUI(url);
}
- virtual bool UseWebUIBindingsForURL(BrowserContext* browser_context,
- const GURL& url) const override {
+ bool UseWebUIBindingsForURL(BrowserContext* browser_context,
+ const GURL& url) const override {
return UseWebUI(url);
}
@@ -78,10 +78,11 @@ class TestInterstitialPageDelegate : public InterstitialPageDelegate {
public:
explicit TestInterstitialPageDelegate(TestInterstitialPage* interstitial_page)
: interstitial_page_(interstitial_page) {}
- virtual void CommandReceived(const std::string& command) override;
- virtual std::string GetHTMLContents() override { return std::string(); }
- virtual void OnDontProceed() override;
- virtual void OnProceed() override;
+ void CommandReceived(const std::string& command) override;
+ std::string GetHTMLContents() override { return std::string(); }
+ void OnDontProceed() override;
+ void OnProceed() override;
+
private:
TestInterstitialPage* interstitial_page_;
};
@@ -130,7 +131,7 @@ class TestInterstitialPage : public InterstitialPageImpl {
*deleted_ = false;
}
- virtual ~TestInterstitialPage() {
+ ~TestInterstitialPage() override {
if (deleted_)
*deleted_ = true;
if (delegate_)
@@ -186,9 +187,7 @@ class TestInterstitialPage : public InterstitialPageImpl {
}
protected:
- virtual WebContentsView* CreateWebContentsView() override {
- return NULL;
- }
+ WebContentsView* CreateWebContentsView() override { return NULL; }
private:
InterstitialState* state_;
@@ -217,12 +216,12 @@ class TestInterstitialPageStateGuard : public TestInterstitialPage::Delegate {
DCHECK(interstitial_page_);
interstitial_page_->set_delegate(this);
}
- virtual ~TestInterstitialPageStateGuard() {
+ ~TestInterstitialPageStateGuard() override {
if (interstitial_page_)
interstitial_page_->ClearStates();
}
- virtual void TestInterstitialPageDeleted(
+ void TestInterstitialPageDeleted(
TestInterstitialPage* interstitial) override {
DCHECK(interstitial_page_ == interstitial);
interstitial_page_ = NULL;
@@ -237,9 +236,9 @@ class WebContentsImplTestBrowserClient : public TestContentBrowserClient {
WebContentsImplTestBrowserClient()
: assign_site_for_url_(false) {}
- virtual ~WebContentsImplTestBrowserClient() {}
+ ~WebContentsImplTestBrowserClient() override {}
- virtual bool ShouldAssignSiteForURL(const GURL& url) override {
+ bool ShouldAssignSiteForURL(const GURL& url) override {
return assign_site_for_url_;
}
@@ -272,16 +271,16 @@ class TestWebContentsObserver : public WebContentsObserver {
explicit TestWebContentsObserver(WebContents* contents)
: WebContentsObserver(contents) {
}
- virtual ~TestWebContentsObserver() {}
+ ~TestWebContentsObserver() override {}
- virtual void DidFinishLoad(RenderFrameHost* render_frame_host,
- const GURL& validated_url) override {
+ void DidFinishLoad(RenderFrameHost* render_frame_host,
+ const GURL& validated_url) override {
last_url_ = validated_url;
}
- virtual void DidFailLoad(RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description) override {
+ void DidFailLoad(RenderFrameHost* render_frame_host,
+ const GURL& validated_url,
+ int error_code,
+ const base::string16& error_description) override {
last_url_ = validated_url;
}
@@ -298,15 +297,15 @@ class TestWebContentsObserver : public WebContentsObserver {
class FakeFullscreenDelegate : public WebContentsDelegate {
public:
FakeFullscreenDelegate() : fullscreened_contents_(NULL) {}
- virtual ~FakeFullscreenDelegate() {}
+ ~FakeFullscreenDelegate() override {}
- virtual void ToggleFullscreenModeForTab(WebContents* web_contents,
- bool enter_fullscreen) override {
+ void ToggleFullscreenModeForTab(WebContents* web_contents,
+ bool enter_fullscreen) override {
fullscreened_contents_ = enter_fullscreen ? web_contents : NULL;
}
- virtual bool IsFullscreenForTabOrPending(const WebContents* web_contents)
- const override {
+ bool IsFullscreenForTabOrPending(
+ const WebContents* web_contents) const override {
return fullscreened_contents_ && web_contents == fullscreened_contents_;
}
@@ -320,9 +319,9 @@ class FakeValidationMessageDelegate : public WebContentsDelegate {
public:
FakeValidationMessageDelegate()
: hide_validation_message_was_called_(false) {}
- virtual ~FakeValidationMessageDelegate() {}
+ ~FakeValidationMessageDelegate() override {}
- virtual void HideValidationMessage(WebContents* web_contents) override {
+ void HideValidationMessage(WebContents* web_contents) override {
hide_validation_message_was_called_ = true;
}
@@ -2453,7 +2452,7 @@ class ContentsZoomChangedDelegate : public WebContentsDelegate {
}
// WebContentsDelegate:
- virtual void ContentsZoomChange(bool zoom_in) override {
+ void ContentsZoomChange(bool zoom_in) override {
contents_zoom_changed_call_count_++;
last_zoom_in_ = zoom_in;
}

Powered by Google App Engine
This is Rietveld 408576698