Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: content/browser/web_contents/web_contents_user_data_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/web_contents_user_data.h" 5 #include "content/public/browser/web_contents_user_data.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "content/public/browser/web_contents.h" 8 #include "content/public/browser/web_contents.h"
9 #include "content/public/test/test_renderer_host.h" 9 #include "content/public/test/test_renderer_host.h"
10 #include "content/public/test/web_contents_tester.h" 10 #include "content/public/test/web_contents_tester.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 class WebContentsAttachedClass1 15 class WebContentsAttachedClass1
16 : public WebContentsUserData<WebContentsAttachedClass1> { 16 : public WebContentsUserData<WebContentsAttachedClass1> {
17 public: 17 public:
18 virtual ~WebContentsAttachedClass1() {} 18 ~WebContentsAttachedClass1() override {}
19
19 private: 20 private:
20 explicit WebContentsAttachedClass1(WebContents* contents) {} 21 explicit WebContentsAttachedClass1(WebContents* contents) {}
21 friend class WebContentsUserData<WebContentsAttachedClass1>; 22 friend class WebContentsUserData<WebContentsAttachedClass1>;
22 }; 23 };
23 24
24 class WebContentsAttachedClass2 25 class WebContentsAttachedClass2
25 : public WebContentsUserData<WebContentsAttachedClass2> { 26 : public WebContentsUserData<WebContentsAttachedClass2> {
26 public: 27 public:
27 virtual ~WebContentsAttachedClass2() {} 28 ~WebContentsAttachedClass2() override {}
29
28 private: 30 private:
29 explicit WebContentsAttachedClass2(WebContents* contents) {} 31 explicit WebContentsAttachedClass2(WebContents* contents) {}
30 friend class WebContentsUserData<WebContentsAttachedClass2>; 32 friend class WebContentsUserData<WebContentsAttachedClass2>;
31 }; 33 };
32 34
33 DEFINE_WEB_CONTENTS_USER_DATA_KEY(WebContentsAttachedClass1); 35 DEFINE_WEB_CONTENTS_USER_DATA_KEY(WebContentsAttachedClass1);
34 DEFINE_WEB_CONTENTS_USER_DATA_KEY(WebContentsAttachedClass2); 36 DEFINE_WEB_CONTENTS_USER_DATA_KEY(WebContentsAttachedClass2);
35 37
36 typedef RenderViewHostTestHarness WebContentsUserDataTest; 38 typedef RenderViewHostTestHarness WebContentsUserDataTest;
37 39
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 ASSERT_TRUE(clazz != NULL); 101 ASSERT_TRUE(clazz != NULL);
100 102
101 WebContentsAttachedClass1::CreateForWebContents(contents); 103 WebContentsAttachedClass1::CreateForWebContents(contents);
102 WebContentsAttachedClass1* class_again = 104 WebContentsAttachedClass1* class_again =
103 WebContentsAttachedClass1::FromWebContents(contents); 105 WebContentsAttachedClass1::FromWebContents(contents);
104 ASSERT_TRUE(class_again != NULL); 106 ASSERT_TRUE(class_again != NULL);
105 ASSERT_EQ(clazz, class_again); 107 ASSERT_EQ(clazz, class_again);
106 } 108 }
107 109
108 } // namespace content 110 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/browser/web_contents/web_contents_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698