Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index ff95ad274c2e4559e855f001c52165d86744f0ae..19c4ff3159436b35d254b23227e34b022f63f649 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -36,11 +36,11 @@ class MessageReceiver : public EmbeddedWorkerTestHelper {
MessageReceiver()
: EmbeddedWorkerTestHelper(kRenderProcessId),
current_embedded_worker_id_(0) {}
- virtual ~MessageReceiver() {}
+ ~MessageReceiver() override {}
- virtual bool OnMessageToWorker(int thread_id,
- int embedded_worker_id,
- const IPC::Message& message) override {
+ bool OnMessageToWorker(int thread_id,
+ int embedded_worker_id,
+ const IPC::Message& message) override {
if (EmbeddedWorkerTestHelper::OnMessageToWorker(
thread_id, embedded_worker_id, message)) {
return true;
@@ -85,13 +85,11 @@ class MessageReceiverFromWorker : public EmbeddedWorkerInstance::Listener {
: instance_(instance) {
instance_->AddListener(this);
}
- virtual ~MessageReceiverFromWorker() {
- instance_->RemoveListener(this);
- }
+ ~MessageReceiverFromWorker() override { instance_->RemoveListener(this); }
- virtual void OnStarted() override { NOTREACHED(); }
- virtual void OnStopped() override { NOTREACHED(); }
- virtual bool OnMessageReceived(const IPC::Message& message) override {
+ void OnStarted() override { NOTREACHED(); }
+ void OnStopped() override { NOTREACHED(); }
+ bool OnMessageReceived(const IPC::Message& message) override {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(MessageReceiverFromWorker, message)
IPC_MESSAGE_HANDLER(TestMsg_MessageFromWorker, OnMessageFromWorker)

Powered by Google App Engine
This is Rietveld 408576698